Re: [PATCH 4/7] Insert breakpoint even when the raw breakpoint is found

Pedro Alves
2016-04-11T14:41:55Z

On 03/23/2016 04:09 PM, Yao Qi wrote:

> ---
> gdb/gdbserver/mem-break.c | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/gdbserver/mem-break.c b/gdb/gdbserver/mem-break.c
> index b06f8e9..af01288 100644
> --- a/gdb/gdbserver/mem-break.c
> +++ b/gdb/gdbserver/mem-break.c
> @@ -411,7 +411,22 @@ set_raw_breakpoint_at (enum raw_bkpt_type type, CORE_ADDR where, int kind,
> if (bp != NULL)
> {
> bp->refcount++;
> - return bp;
> +
> + if (!bp->inserted)
> + {
> + *err = the_target->insert_point (bp->raw_type, bp->pc, bp->kind,
> + bp);
> + if (*err != 0)
> + {
> + if (debug_threads)
> + debug_printf ("Failed to insert breakpoint at 0x%s (%d).\n",
> + paddress (where), *err);
> + bp->refcount--;

Can we only increase the refcount if inserting succeeds? gdbserver can
use gdb exceptions nowadays, and even though lots of current gdbserver
code isn't exception safe, it'd be nice to start considering that.

> + return NULL;
> + }
> + bp->inserted = 1;
> + }
> + return bp;
> }
>
> bp = XCNEW (struct raw_breakpoint);
>

Thanks,
Pedro Alves