Re: [PATCH 1/2] Include the fs_base and gs_base registers in amd64 target descriptions.

John Baldwin
2017-07-11T16:26:14Z

On Tuesday, July 11, 2017 09:01:25 AM Yao Qi wrote:
> John Baldwin <jhb@FreeBSD.org> writes:
>
> > This permits these registers to be used with non-Linux targets.
>
> Some GDBserver uses these target description files, like
> x86_64-*-mingw*, after this change, GDBserver will reply GDB the target
> description including "64bit-segments.xml". Then, GDB will request the
> contents of 64bit-segments.xml from GDBserver, looks 64bit-segments.xml
> is already builtin in GDBserver, so there isn't an issue here.
>
> The patch is good to me.
>
> P.S. this is a good example to show the inflexibility in current target
> description. After we change it to my new approach of target
> description, this change will be just two or three lines :)

Agreed. :) The combinatorics with XSAVE on x86 is especially bad.

--
John Baldwin