From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id bXGCCtl66GXFBzsAWB0awg (envelope-from ) for ; Wed, 06 Mar 2024 09:16:57 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=Trw6yrsU; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1AC881E0D2; Wed, 6 Mar 2024 09:16:57 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0513F1E092 for ; Wed, 6 Mar 2024 09:16:55 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 771253857C65 for ; Wed, 6 Mar 2024 14:16:54 +0000 (GMT) Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 81C183857C4F for ; Wed, 6 Mar 2024 14:16:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 81C183857C4F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 81C183857C4F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709734595; cv=none; b=ryL+3w1iUONumMdQOroY2h8OIvPt3oRWm2Rj5gD4XfmEWT+WNmJkuGwYgCCCeSGyAiO60DdTas4exUMLLb3BmALIzgxCztHtnixZBdFxxHBIEcqUU9utsBL6WfgPqQqwA2kNDAfBa4S3H7mB+nQRlSEU1MBZ9pKEZsOQ5MkT8zA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709734595; c=relaxed/simple; bh=dD9thh2D15KtI9rIMptK0iBGu48DKDZpWSFZR51INpQ=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=CkMYXKf4pWdjOOpJTGVoz+F6XaNbSrD84yhDfYR/ntet+HQhcrweRRWFEI/90LWrMwBYsHajW8zltkyTfutAnb0TMFuxcwLzj6Ekr5fKrTGgw0GOaJPMYXXntmeuZg5BJwfipG0Qno71ST91JHDnyCX3vtU7WliNKy7kgdlmkqc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhs4K-00074f-Gf; Wed, 06 Mar 2024 09:16:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=zcBDMVASZSKOB2764hW3YWfSrW9ss2v+yM1SJEvgF78=; b=Trw6yrsU5p7Y 9CwEfm1QpGVfuqUOaSf3C01C77WVoobx6e60mPrN62NW8JhfQzow8St5AsMlCGuY2gFw6Br/ZHQL2 tMSnCrX3qtTYO3Obs3M1Yn1qtVgLMm4VT3QGvB76cocHbOaxC4JLfpi+drwmkJcSdQwHwV3VgksVs zhHo6N3262XjyG2E8G/2NlwwD3tW9u50CLpokeeIRTo1zNjE3L+5rhcOgrHZmz3ZZxT5XFclRgLq1 SPSKv9nru9foFAaFxg3iFa5ru36c7Rt8bFQlq2GoNHc1Heu2M+lVYSIGfZcvsOgmACqK0oA98YFQe q+mrekWlk9AOADWghqxesA==; Date: Wed, 06 Mar 2024 16:16:23 +0200 Message-Id: <86y1avjvig.fsf@gnu.org> From: Eli Zaretskii To: Guinevere Larsen Cc: gdb-patches@sourceware.org In-Reply-To: <5760021d-9de3-492d-af65-225e61971901@redhat.com> (message from Guinevere Larsen on Wed, 6 Mar 2024 15:07:17 +0100) Subject: Re: [PATCH 4/4] GDB: introduce ability to disable frame unwinders References: <20240306125135.766567-1-blarsen@redhat.com> <20240306125135.766567-5-blarsen@redhat.com> <86zfvbjwui.fsf@gnu.org> <5760021d-9de3-492d-af65-225e61971901@redhat.com> X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org > Date: Wed, 6 Mar 2024 15:07:17 +0100 > Cc: gdb-patches@sourceware.org > From: Guinevere Larsen > > >> +The meaning of the argument @samp{unwinder} depends on the @samp{option} > > The correct markup here is @var, not @samp, since these are not > > literal symbols, but instead names of parameters that stand for > > something else. Likewise elsewhere in the gdb.texinfo part of the > > patch. > > Ah, thanks for explaining! Should I also change the @samp in the table > section? Only for @samp{unwinder} and @samp{option}. The rest are literals, like "-all". > >> +The class may include the prefix @code{FRAME_UNWINDER_}, but it is not > >> +required. This is the default option. > > What do you mean by the last sentence? What is "this" that is the > > default option? And what does "default" mean for an option, since an > > option is by definition something that doesn't happen by default. > > option is an optional parameter, and if the user decides to not provide > it, the command will work as if the user had provided the -class option. Then I suggest to rephrase like this: By default, @var{unwinder} is interpreted as a class, even if @samp{-class} was omitted.