Re: [PATCH] gdb/doc: qSearch:memory packets use escaped binary patterns

[Eli Zaretskii <eliz@gnu.org>]

> From: Aaron Griffith <aargri@gmail.com>
> Date: Sat, 16 Aug 2025 16:52:54 -0400
> 
> The `qSearch:memory` packet uses hex encoding for the address and
> length arguments, but the search-pattern argument uses escaped binary.
> 
> ---
> This documentation change can be confirmed two ways:
> 
>  * Inspect the packets sent by gdb with `set debug remote`, and then
>    search memory with e.g. `find &buf[0], +sizeof(buf), "foo"`.
> 
> * The implementation `search_memory` in gdb/remote.c uses
>    `remote_escape_output` for the pattern argument, and this function
>    is documented as encoding escaped binary data.
> ---
>  gdb/doc/gdb.texinfo | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index d4a5a632c24306f6c0ff6bd6d14e01a847e9a494..0ae15642c0d1b92f08bbd16011cf0214deec6dfa 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -44887,7 +44887,8 @@ packets.)
>  @anchor{qSearch memory}
>  Search @var{length} bytes at @var{address} for @var{search-pattern}.
>  Both @var{address} and @var{length} are encoded in hex;
> -@var{search-pattern} is a sequence of bytes, also hex encoded.
> +@var{search-pattern} is a sequence of binary-encoded bytes
> +(@pxref{Binary Data}).
>  
>  Reply:
>  @table @samp

Thanks, this is okay, as far as the Texinfo markup and the language
are concerned (I have no knowledge about the actual issue, but I
expect others to comment if they disagree).

Approved-By: Eli Zaretskii <eliz@gnu.org>