Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Klaus Gerlicher <klaus.gerlicher@intel.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 1/1] gdb/linespec: relax block filter to preserve distinct code paths
Date: Thu, 04 Jun 2026 17:45:39 +0300	[thread overview]
Message-ID: <86y0gus6ss.fsf@gnu.org> (raw)
In-Reply-To: <20260604132938.416526-2-klaus.gerlicher@intel.com> (message from Klaus Gerlicher on Thu, 4 Jun 2026 13:29:38 +0000)

> From: Klaus Gerlicher <klaus.gerlicher@intel.com>
> Date: Thu,  4 Jun 2026 13:29:38 +0000
> 
>  gdb/NEWS                                      |  11 +
>  gdb/amd64-tdep.c                              |  57 ++++
>  gdb/arch-utils.c                              |  10 +
>  gdb/arch-utils.h                              |   1 +
>  gdb/gdbarch-gen.c                             |  22 ++
>  gdb/gdbarch-gen.h                             |  10 +
>  gdb/gdbarch_components.py                     |  15 ++
>  gdb/linespec.c                                |  98 ++++++-
>  .../gdb.linespec/block-filter-cases.c         | 126 +++++++++
>  .../gdb.linespec/block-filter-cases.exp       | 248 ++++++++++++++++++
>  10 files changed, 595 insertions(+), 3 deletions(-)
>  create mode 100644 gdb/testsuite/gdb.linespec/block-filter-cases.c
>  create mode 100644 gdb/testsuite/gdb.linespec/block-filter-cases.exp

Thanks.

> diff --git a/gdb/NEWS b/gdb/NEWS
> index 7c8cf9af4c2..f55b6518344 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -64,6 +64,17 @@
>    This fixes an issue where GDB could fail to find a type when relying
>    on the index.  Any existing indexes should be regenerated.
>  
> +* Breakpoint location resolution has been improved for vectorized loops.
> +  Previously, when setting a breakpoint on a source line with vectorized
> +  code (at -O2 with -ftree-vectorize), GDB's block filter heuristic would
> +  discard the scalar remainder location, causing breakpoints to be missed
> +  when only the scalar path executed. GDB now correctly preserves multiple
                                       ^^
Please leave two spaces between sentences, per our conventions.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>

      reply	other threads:[~2026-06-04 14:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-04 13:29 [PATCH v2 0/1] Fix block filter heuristic in linespec " Klaus Gerlicher
2026-06-04 13:29 ` [PATCH v2 1/1] gdb/linespec: relax block filter " Klaus Gerlicher
2026-06-04 14:45   ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86y0gus6ss.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=klaus.gerlicher@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox