Re: [PATCH 01/10] Fix breakpoint size when stepping over a permanent breakpoint in GDBServer.

Antoine Tremblay
2015-11-03T17:05:02Z

On 11/03/2015 11:21 AM, Yao Qi wrote:
> Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
>
>> static int
>> -arm_breakpoint_at (CORE_ADDR where)
>> +arm_is_thumb_mode (void)
>> {
>
> Please add comments to arm_is_thumb_mode.

Fixed as : /* Returns 1 if the current instruction set is thumb, 0
otherwise. */

>
>> diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h
>> index 769c876..f0fb9d7 100644
>> --- a/gdb/gdbserver/target.h
>> +++ b/gdb/gdbserver/target.h
>> @@ -451,6 +451,12 @@ struct target_ops
>> specific meaning like the Z0 kind parameter.
>> SIZE is set to the software breakpoint's length in memory. */
>> const gdb_byte *(*sw_breakpoint_from_kind) (int kind, int *size);
>> +
>> + /* Return the breakpoint kind for this target based on the current state
>
> Maybe "current machine state" or "current processor state" is better
> than "current state"?

Agreed. set as "current processor state"

>
>> + (e.g. the current instruction mode on ARM) and the PC. The PCPTR is
>
> Two spaces before "The PCPTR".

Fixed.
>
>> + adjusted to the real memory location in case a flag (e.g., the Thumb
>> + bit on ARM) was present in the PC. */
>
> "is present in the PC." ?
>

Fixed, thanks.