Re: [PATCH 05/10] Remove too simple breakpoint_reinsert_addr implementations.

Pedro Alves
2015-11-04T18:21:45Z

On 10/29/2015 05:09 PM, Antoine Tremblay wrote:
> This patch removes too simple implementations of the breakpoint_reinsert_addr
> operation.
>
> The only reason to keep them around was to support thread events when
> PTRACE_EVENT_CLONE was not present but this support has been removed in a
> previous patch.
>
> No regressions, tested on ubuntu 14.04 ARMv7 and x86.
> With gdbserver-{native,extended} / { -marm -mthumb }
>
> Also compilation was tested on aarch64, bfin, cris, crisv32,
> m32r, mips, nios2, ppc, s390, sparc, tic6x, tile, xtensa.
>
> gdb/gdbserver/ChangeLog:
>
> * linux-arm-low.c (arm_reinsert_addr): Remove function.
> (struct linux_target_ops <breakpoint_reinsert_addr>: Set to NULL.
> * linux-cris-low.c (cris_reinsert_addr> Remove function.
> (struct linux_target_ops) <breakpoint_reinsert_addr>: Set to NULL.
> * linux-crisv32-low.c (cris_reinsert_addr): Remove function.
> (struct linux_target_ops) <breakpoint_reinsert_addr>: Set to NULL.
> * linux-mips-low.c (mips_reinsert_addr): Remove function.
> (struct linux_target_ops) <breakpoint_reinsert_addr>: Set to NULL.
> * linux-nios2-low.c (nios2_reinsert_addr): Remove function.
> (struct linux_target_ops) <breakpoint_reinsert_addr>: Set to NULL.
> * linux-sparc-low.c (sparc_reinsert_addr): Remove function.
> (struct linux_target_ops) <breakpoint_reinsert_addr>: Set to NULL;

Typo in last "Set to NULL;".

Otherwise LGTM.

Thanks,
Pedro Alves