Re: [PATCH v4 0/6] Support software single step and conditional breakpoints on ARM in GDBServer.

Antoine Tremblay
2015-12-02T13:52:12Z

On 12/02/2015 08:36 AM, Pedro Alves wrote:
> On 12/02/2015 01:17 PM, Antoine Tremblay wrote:
>> In this v4:
>>
>> Patches [1-5] of the v3 have been pushed in.
>>
>> A new patch 3 is now introduced to refactor arm_software_single_step to
>> use regcache instead of frame so that we can share the registry reading
>> function regcache_raw_read_unsigned between GDB and GDBServer.
>>
>> This allows the removal of the operation collect_register_unsigned from
>> the get_next_pcs context structure.
>>
>> Patch 1: is OK.
>> Patch 2: is OK.
>> Patch 3: New patch needs review.
>> Patch 4: Needs review. This was adapted based on the new patch 3.
>> Patch 5: is OK.
>> Patch 6: is OK.
>
> Is the syscall issue fixed in this version?
>

Yes sorry amazingly I forgot to add this to the comment log.

Patch 4 comment is updated to remove the limitation, however.

Regards,
Antoine