From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53447 invoked by alias); 3 Dec 2015 14:49:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53421 invoked by uid 89); 3 Dec 2015 14:49:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pf0-f175.google.com Received: from mail-pf0-f175.google.com (HELO mail-pf0-f175.google.com) (209.85.192.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 03 Dec 2015 14:49:13 +0000 Received: by pfdd184 with SMTP id d184so9692864pfd.3 for ; Thu, 03 Dec 2015 06:49:11 -0800 (PST) X-Received: by 10.98.19.12 with SMTP id b12mr13611378pfj.78.1449154151095; Thu, 03 Dec 2015 06:49:11 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id f67sm11297699pfd.9.2015.12.03.06.49.07 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 03 Dec 2015 06:49:09 -0800 (PST) From: Yao Qi To: Antoine Tremblay Cc: Yao Qi , Subject: Re: [PATCH v4 4/6] Support software single step on ARM in GDBServer. References: <1449062264-18565-1-git-send-email-antoine.tremblay@ericsson.com> <1449062264-18565-5-git-send-email-antoine.tremblay@ericsson.com> <86a8pru6hf.fsf@gmail.com> <56604A85.5030805@ericsson.com> Date: Thu, 03 Dec 2015 14:49:00 -0000 In-Reply-To: <56604A85.5030805@ericsson.com> (Antoine Tremblay's message of "Thu, 3 Dec 2015 08:58:29 -0500") Message-ID: <86wpsvsi3k.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00050.txt.bz2 Antoine Tremblay writes: > byte_order fields seemed like a good idea at first and I liked your > suggested change for read_memory_unsigned_integer. > > However GDB is using 2 byte orders : byte_order (for data) and > byte_order_for_code to support BE8 endianness. > > This complicates things a bit since in common code I can't call: > > self->ops->read_memory_unsigned_integer (self, loc, 2) > > I would have no way to specify if it should read with byte_order or > with byte_order_for_code. We can use two methods for reading data and reading instructions respectively, and we can hide byte_order and byte_order_for_code still. Anyway, I strong opinion on this, either way is OK to me. > const gdb_byte *arm_thumb2_breakpoint: This one needs to stay, since > while on GDB's side it could be computed through regcache/gdbarch, on > GDBServer's side it's directly a variable. OK. --=20 Yao (=E9=BD=90=E5=B0=A7)