From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44260 invoked by alias); 9 May 2017 13:54:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44249 invoked by uid 89); 9 May 2017 13:54:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-wr0-f169.google.com Received: from mail-wr0-f169.google.com (HELO mail-wr0-f169.google.com) (209.85.128.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 09 May 2017 13:54:06 +0000 Received: by mail-wr0-f169.google.com with SMTP id l50so74133230wrc.3 for ; Tue, 09 May 2017 06:54:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=LiZQkeVufS2zx3p+FtAS5SrsBNWcYJyNBQxu9g8FCCU=; b=Nbx1LwhNx46YkmXsmdih0DQXfh6SUo/KgorHvDDdgQl+eWSy4f9H61w1JW4V4mINC9 g6jHC166pwp65wyXezLGeoCuA0W8Ekd7nGoq3ZdWsWvpt+vGJEBiGTti8zn5ChqY6htB DCoUkLPIatu91iipy9Z5Ru4FomrVidBGsrYOhBI/sVw0DloGUDIBxfJ1rhOKVDvD178N RMCauu6+7gRcq2479A1cAudPWuKSdvbpCtaN+f+0SOLG7StDtDGc0ZE/fqx4qapxwwsG FSdKN6N7zO9Mrx4cfOqtE6AuUTWiQKgrvfVpq/tYMGx9ZHZVuti1NVYX7posgRgpdI5n GtMw== X-Gm-Message-State: AODbwcADdEAQlvCNidvwDOCOTp0xOmsy/WZe+hvuAJEOlkM4NrGsmec+ y05gKZHIxQJYqlY1 X-Received: by 10.28.153.11 with SMTP id b11mr1241496wme.141.1494338047254; Tue, 09 May 2017 06:54:07 -0700 (PDT) Received: from E107787-LIN ([194.214.185.158]) by smtp.gmail.com with ESMTPSA id r29sm13735056wra.18.2017.05.09.06.54.06 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 09 May 2017 06:54:06 -0700 (PDT) From: Yao Qi To: Stafford Horne Cc: GDB patches , Openrisc , Franck Jullien Subject: Re: [PATCH v6 1/5] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p References: <86r307725n.fsf@gmail.com> <20170502154115.GH2724@lianli.shorne-pla.net> Date: Tue, 09 May 2017 13:54:00 -0000 In-Reply-To: <20170502154115.GH2724@lianli.shorne-pla.net> (Stafford Horne's message of "Wed, 3 May 2017 00:41:15 +0900") Message-ID: <86wp9qt9ty.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00211.txt.bz2 Stafford Horne writes: > This change is to also allow returning true in the case that the register > group was registered with gdb with reggroup_add(). This seems like > something that will be generally required so it was added to the > target-descriptions definition. If you think not I can make it for > openrisc only, but I think it makes more sense in tdesc. Thanks for the explanation. > > This allows the command like, the below to return the registers for the > named reggroup. > > info reg system Some bits are missing, - A test case, in which we can define some reggroups "foo" and test expected "foo" is shown in the output of "maintenance print reggroups". You can add reggroups in gdb.xml/extra-regs.xml. - A test case with live inferior, get a list of support reggroups from the output of "maint print reggroups", pass each reggroup to "info reg $group", and test there is no error. - Document "info registers". https://sourceware.org/gdb/current/onlinedocs/gdb/Registers.html doesn't document the usage "info reg GROUP". We need to add it. - Add a news entry, because your patch adds a user visible change. --=20 Yao (=E9=BD=90=E5=B0=A7)