From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56711 invoked by alias); 15 May 2017 09:32:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56701 invoked by uid 89); 15 May 2017 09:32:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1366, H*RU:209.85.192.193, Hx-spam-relays-external:209.85.192.193 X-HELO: mail-pf0-f193.google.com Received: from mail-pf0-f193.google.com (HELO mail-pf0-f193.google.com) (209.85.192.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 15 May 2017 09:32:49 +0000 Received: by mail-pf0-f193.google.com with SMTP id w69so15153237pfk.1 for ; Mon, 15 May 2017 02:32:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Ff1KO3cEtbrrjc0IGuU3kI9ks99JsnuWRmXy+fg35S0=; b=kvNho4zVTK+K8N7FrgS1c7IR0a/6/tzd8gQ1Z9xZmrnoriZSwif29jEng77/wIqOR+ Sa/H/Hhh2RcL2GJtw2G8e02c+irP095LVRB6Ltv3RP4/CZLKTe5xVgLe6A9lOQqbzj8e 3t5lqqEq57VdYTUwxYRRzhNW5guAYh90hu7m7+s6ZzFzS52e848u1fxkwpIe4t8Nl3Eo +k19ChY4Z6HAcu/neg51SxU2oryLhUC8bWNIH03hY9zzCl+23JlX6D8fiL1Rmc/tv+nA afjUhGkDnDhX/FvvU+qSNuCtnoLFAWtqXd+a1nqcde6k+NGUyGXoNzuaOnBO0lPNv64j D/uA== X-Gm-Message-State: AODbwcAVYHM2CFyb3FJ+QV+aNpj0rpSJ59f2vi5nYph3BKpwfFpQcUZx xaJcE11vAmgoZSc/ X-Received: by 10.99.116.82 with SMTP id e18mr5081658pgn.1.1494840771003; Mon, 15 May 2017 02:32:51 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id 7sm17671678pff.36.2017.05.15.02.32.49 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 15 May 2017 02:32:50 -0700 (PDT) From: Yao Qi To: Andreas Arnez Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 03/19] PR gdb/21226: Take DWARF stack value pieces from LSB end References: <1494352015-10465-1-git-send-email-arnez@linux.vnet.ibm.com> <1494352015-10465-4-git-send-email-arnez@linux.vnet.ibm.com> Date: Mon, 15 May 2017 09:32:00 -0000 In-Reply-To: <1494352015-10465-4-git-send-email-arnez@linux.vnet.ibm.com> (Andreas Arnez's message of "Tue, 9 May 2017 19:45:59 +0200") Message-ID: <86wp9icvnn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00319.txt.bz2 Andreas Arnez writes: > * DW_OP_piece shall take the piece from the LSB end as well; > My understanding is that this is true for a given arch or ABI. This change will affect other big-endian architectures, like mips. > @@ -1866,26 +1870,30 @@ read_pieced_value (struct value *v) > p->v.mem.in_stack_memory, > p->v.mem.addr + source_offset, > buffer.data (), this_size); > + copy_bitwise (contents, dest_offset_bits, > + intermediate_buffer, source_offset_bits % 8, > + this_size_bits, bits_big_endian); > break; >=20=20 > case DWARF_VALUE_STACK: > { > - size_t n =3D this_size; > + struct objfile *objfile =3D dwarf2_per_cu_objfile (c->per_cu); > + struct gdbarch *objfile_gdbarch =3D get_objfile_arch (objfile); > + ULONGEST stack_value_size_bits > + =3D 8 * TYPE_LENGTH (value_type (p->v.value)); >=20=20 > - if (n > c->addr_size - source_offset) > - n =3D (c->addr_size >=3D source_offset > - ? c->addr_size - source_offset > - : 0); > - if (n =3D=3D 0) > - { > - /* Nothing. */ > - } > - else > - { > - const gdb_byte *val_bytes =3D value_contents_all (p->v.value); > + /* Use zeroes if piece reaches beyond stack value. */ > + if (p->size > stack_value_size_bits) > + break; Does this indicate something wrong in DWARF producer? Does GDB need to emit a complaint? --=20 Yao (=E9=BD=90=E5=B0=A7)