From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94447 invoked by alias); 13 Jun 2017 12:07:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94432 invoked by uid 89); 13 Jun 2017 12:07:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,GIT_PATCH_1,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:static. X-HELO: mail-it0-f51.google.com Received: from mail-it0-f51.google.com (HELO mail-it0-f51.google.com) (209.85.214.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Jun 2017 12:07:23 +0000 Received: by mail-it0-f51.google.com with SMTP id m47so39346212iti.1 for ; Tue, 13 Jun 2017 05:07:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Ka9M8AvA9wy3UkV3Mea6W2ZhhE0TImIoyaNeAJ+slak=; b=IbR/eb3hhGTkGdAh5IBcsP7z/VSCpLrTfBRcTms1r5xDo/BhO3kBN2Yj34w7894PCC 5pUE57yeC5XCIqUsaDeUGUCSetbvrgoQoAX0trjXs++yq+IjLSwnbizDDz7mXqC7gGtu hunigpV2bqTqJGd9G0g+H4gnh5+cWRnljE2TtuaV7sybcfgLqXmmSy05GofCS/Ga/lFu tIg4pakfqxNGGmkb7ScZyEXJIRhFvz60ZcRD28q5sVQ5bVWRkWqHE8iD0faMtlMMBnR2 BBWNIP3JdHx8VLgc4BRRDfPOp7DhnkwAyX48FCcQDkqzuBYAg9OpUqwL6DBK0YY8mUSB 7CQQ== X-Gm-Message-State: AODbwcDUUXHTyRjYrTtL8KffcOAN99w+E3INg40/dIoo4nGuvTy9EYmI TZJrySy8XT8f40B/ X-Received: by 10.36.51.82 with SMTP id k79mr17156835itk.32.1497355646507; Tue, 13 Jun 2017 05:07:26 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id n73sm1625168itb.13.2017.06.13.05.07.25 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 13 Jun 2017 05:07:26 -0700 (PDT) From: Yao Qi To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 06/25] Generate c for feature instead of tdesc References: <1497256916-4958-1-git-send-email-yao.qi@linaro.org> <1497256916-4958-7-git-send-email-yao.qi@linaro.org> <837f0h5kjz.fsf@gnu.org> Date: Tue, 13 Jun 2017 12:07:00 -0000 In-Reply-To: <837f0h5kjz.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 12 Jun 2017 17:48:16 +0300") Message-ID: <86wp8gccqv.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00375.txt.bz2 Eli Zaretskii writes: >> The created >> +source file can be used in @value{GDBN} when an XML parser is not >> +available to parse the description. > > I also have some clarification requests (and I do realize that the > original text had the same issues): > > . I think we should say a few words regarding the argument FILE: I > don't believe _any_ file will do in this role, so we should tell > what kind of files are expected here. It is an XML target description. > . "The created source file can be used in GDB ..." -- used how? I'd > prefer that we said a sentence or tow about that as well, or had a > cross-reference to where that is described. The created source file is built into GDB. How is the doc and NEWS entry below? Note that I removed the last sentence "... when an XML parser is not available to parse the description", because these created c files are builtin target descriptions which are used too when an XML parser is available. @kindex maint print c-tdesc @r{[}@var{file}@r{]} @item maint print c-tdesc Print the target description (@pxref{Target Descriptions}) as a C source file. By default, the target description is for the current target, but if the optional argument @var{file} is provided, that file is used to produce the description. The @var{file} is an XML document, of the form described in @ref{Target Description Format}. The created source file is built in @value{GDBN}. > > Also, what about a NEWS entry? * The "maintenance print c-tdesc" command now takes an optional argument which is the file name of XML target description. --=20 Yao (=E9=BD=90=E5=B0=A7)