From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88128 invoked by alias); 10 Jan 2018 13:01:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88119 invoked by uid 89); 10 Jan 2018 13:01:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:static. X-HELO: mail-wr0-f178.google.com Received: from mail-wr0-f178.google.com (HELO mail-wr0-f178.google.com) (209.85.128.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Jan 2018 13:01:23 +0000 Received: by mail-wr0-f178.google.com with SMTP id p6so17254367wrd.0 for ; Wed, 10 Jan 2018 05:01:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=3bmve/goehQN7GdGwknBXQWmCTvnrTkThosK3Kc+YT4=; b=OcdVoEjuQFZrw7KFyW1kVC9F0gxTaTA5Awk8Yf6RyiS5S6ws9Xg77KmEVUg3F0HvFW e4/rKtI2OkHUD/K6Qpb13N6kZR2Os9+dDW3HOIvCRkcJjaT4tAczkVyocIePkN69Nj5d vZ3uFiJHh0trOn+p9ky/5wshL64Nw0BTeZAlF7r+Ep18ruRSeSA+uCWMqa0402anKfnL 1GAx6OLk6DOIBe8SDCrdrGNimQw4+C/uSwMQX7htHbrTutBbLw6huWjWTn4E73SXpt3y jbS3a7H5RKVF3O73bIBPWWHCuHODwNWzpXGesEg1Dsdt90TRIZ6OG2UyRAf736chz8Mw ZFAA== X-Gm-Message-State: AKwxytd/HgHkSsny/vuqYMGnOQq3wK8o5uHxBn3ustYQEbBrOGVxhWIh Ll99+2hADEE3m8rsNnqLEdMEsw== X-Google-Smtp-Source: ACJfBoutnZ0PN9sEqrCmu8thZqSe5d4RKOGYs3UdtjLNtq0xtfRXjc2v/XKHaLib4BqZA0eGs+msyQ== X-Received: by 10.223.160.87 with SMTP id l23mr1051613wrl.51.1515589280871; Wed, 10 Jan 2018 05:01:20 -0800 (PST) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id o65sm18260908wmi.42.2018.01.10.05.01.19 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 10 Jan 2018 05:01:20 -0800 (PST) From: Yao Qi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 5/6] Remove objfile argument from add_dyn_prop References: <20180106002621.21099-1-tom@tromey.com> <20180106002621.21099-6-tom@tromey.com> Date: Wed, 10 Jan 2018 13:01:00 -0000 In-Reply-To: <20180106002621.21099-6-tom@tromey.com> (Tom Tromey's message of "Fri, 5 Jan 2018 17:26:20 -0700") Message-ID: <86wp0pg95s.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00198.txt.bz2 Tom Tromey writes: > @@ -25116,7 +25116,7 @@ set_die_type (struct die_info *die, struct type *= type, struct dwarf2_cu *cu) > if (attr_form_is_block (attr)) > { > if (attr_to_dynamic_prop (attr, die, cu, &prop)) > - add_dyn_prop (DYN_PROP_ALLOCATED, prop, type, objfile); > + add_dyn_prop (DYN_PROP_ALLOCATED, prop, type); > } Before the patch, the objfile is cu->per_cu->dwarf2_per_objfile->objfile, but after the patch, the objfile is TYPE_OBJFILE (type), are they equivalent? --=20 Yao (=E9=BD=90=E5=B0=A7)