Re: [PATCH] Fix windows_nat_target::fake_create_process ptid

[Eli Zaretskii <eliz@gnu.org>]

> From: Pedro Alves <pedro@palves.net>
> Date: Fri, 22 Mar 2024 19:30:30 +0000
> 
> While working on Windows non-stop mode, I managed to introduce a bug
> that led to fake_create_process being called.  That then resulted in
> GDB crashes later on, because fake_create_process added a thread with
> an incorrect ptid for this target.  It is putting dwThreadId in the
> tid field of the ptid instead of on the lwp field.  This is fixed by
> this patch.
> 
> I do however wonder why nobody has seen it this long.

AFAIU, to actually see the bug, one would need to attach GDB to a
process whose main thread has exited, is that true?  If so, I'm not
surprised this bug was not reported: it's unusual for the main thread
to exit without shutting down the process, and the need to attach to
such a process (as opposed to having it run from GDB to begin with)
makes that even more rare.  And finally, not every bug is reported by
the first person who sees it the first time, right?