From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ARbYDA+OnGjmbQIAWB0awg (envelope-from ) for ; Wed, 13 Aug 2025 09:07:27 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=Dm3GkwsA; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2FEA91E04C; Wed, 13 Aug 2025 09:07:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 76F7E1E04C for ; Wed, 13 Aug 2025 09:07:26 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E976E3858C53 for ; Wed, 13 Aug 2025 13:07:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E976E3858C53 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=Dm3GkwsA Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 87449385840D for ; Wed, 13 Aug 2025 13:05:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 87449385840D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 87449385840D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755090356; cv=none; b=RqOIDfchPb/DqXwxKvyFh65mQhxjxOBl8KQIT7UODJ2FQ+uQaWncMluTfPYOhsDthApKMZfebal5KrzUwsLuk6KTz6UXG35rr2HO4FuGaKNpkvkDu6YF05QNVdu67MeLB1Jpw2hxzS9llbzrSTrZjUJwYVAdt8xRb9gaVwRukVY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755090356; c=relaxed/simple; bh=QXH3mhc/V8jaBHxUNxMURuwbI4wc4w6IVc270Yjw/Go=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=eJdzknIqr4HDa/ylz973c05T2qQLHeYAeb1/NZUsqZ7TUchBol15iJdxHkWKZgOVRE9AfxNv+oM1vakVdUEkuCNODPvuu9040uHx/a2rGeku5CtlgM71omx1t+xYJBqP1WWZEca2NNCcrQ65TeDsL9YUgU1xaiuxVWUz1X/a9UY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 87449385840D Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1umBAx-0003je-UI; Wed, 13 Aug 2025 09:05:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RsHh0hnRLqRquaBfsrYXKp2gpP0UXqOqCVlnCh1yft0=; b=Dm3GkwsAKvyI IdRyZWgxvC+Rs4SDgBNMWn7U6cKIFv2vajm8pJjEVzzaqhUA0HCRdH3MWs8lY6+Fx4ny/qSkafgd6 x4LQNDii2IfbTp2J2DENyVJFH/N3MSdeKO8OLzI+fi4AhXBmfjDhA4PddX/zfBGkILjImVTp/nOyA 8+G3RdJ2cqZaclsAqrUAjhLTH2aFvTPGVFpGJt/xTxe9TYf5wwfQ2e+cQHjazocHRf3RsZ9+GBmJI ogPTIghHrpRfoykH6WumZc5cfm32haS2omKKVeX3xWenThiA7XsgO64WYSUXV5A2ELkIWz3rm4Tv2 tqW+YUCYrDpyvyxooEUNUQ==; Date: Wed, 13 Aug 2025 16:05:52 +0300 Message-Id: <86wm77mkwf.fsf@gnu.org> From: Eli Zaretskii To: Andrew Burgess Cc: gdb-patches@sourceware.org In-Reply-To: <76fa89c16d227269ea23273b6039b9cc3afcdb1f.1755080429.git.aburgess@redhat.com> (message from Andrew Burgess on Wed, 13 Aug 2025 11:34:30 +0100) Subject: Re: [PATCHv7 3/4] gdb/python: new class gdb.StyleParameterSet References: <76fa89c16d227269ea23273b6039b9cc3afcdb1f.1755080429.git.aburgess@redhat.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > From: Andrew Burgess > Cc: Andrew Burgess > Date: Wed, 13 Aug 2025 11:34:30 +0100 > > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -144,6 +144,10 @@ info threads [-gid] [-stopped] [-running] [ID]... > gdb.INTENSITY_DIM for use with gdb.Style when representing > intensities. > > + ** New gdb.StyleParameterSet for creating custom style settings. > + Use gdb.StyleParameterSet(NAME) to create 'set style NAME ...' > + and 'show style NAME ...' parameters. > + This part is okay. > +@smallexample > +@group > +(@value{GDBP}) python s = gdb.StyleParameterSet("my-style") > +(@value{GDBP}) show style my-style > +style my-style background: The "my-style" style background color is: none > +style my-style foreground: The "my-style" style foreground color is: none > +style my-style intensity: The "my-style" style display intensity is: normal > +(@value{GDBP}) > +@end group > +@end smallexample > + > +You might also want to group a number of styles within a new prefix, > +similar to how @value{GDBN} groups disassembler related styles within > +the @samp{style disassembler} prefix. This can be done using > +@code{gdb.ParameterPrefix} (@pxref{gdb.ParameterPrefix}), as in this > +example: > + > +@smallexample > +@group > +(@value{GDBP}) python gdb.ParameterPrefix("style my-group", gdb.COMMAND_NONE) > +(@value{GDBP}) python s_a = gdb.StyleParameterSet("my-group aaa") > +(@value{GDBP}) python s_b = gdb.StyleParameterSet("my-group bbb") > +(@value{GDBP}) show style my-group > +style my-group aaa background: The "my-group aaa" style background color is: none > +style my-group aaa foreground: The "my-group aaa" style foreground color is: none > +style my-group aaa intensity: The "my-group aaa" style display intensity is: normal > +style my-group bbb background: The "my-group bbb" style background color is: none > +style my-group bbb foreground: The "my-group bbb" style foreground color is: none > +style my-group bbb intensity: The "my-group bbb" style display intensity is: normal These line are too long. Could you make the strings shorter, so that the lines became shorter? Okay, with the above fixed, thanks. Reviewed-By: Eli Zaretskii