From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15484 invoked by alias); 28 Dec 2002 12:39:27 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15476 invoked from network); 28 Dec 2002 12:39:24 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (62.163.169.250) by 209.249.29.67 with SMTP; 28 Dec 2002 12:39:24 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6/8.12.5) with ESMTP id gBSCcX8M000469; Sat, 28 Dec 2002 13:38:33 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6/8.12.6) with ESMTP id gBSCcXZf022797; Sat, 28 Dec 2002 13:38:33 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6/8.12.6/Submit) id gBSCcX6K022794; Sat, 28 Dec 2002 13:38:33 +0100 (CET) To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: RFC/gdbarch: Make OS ABI a real member of the gdbarch References: <20021228001850.GA2127@nevyn.them.org> From: Mark Kettenis Date: Sat, 28 Dec 2002 05:13:00 -0000 In-Reply-To: Daniel Jacobowitz's message of "Fri, 27 Dec 2002 19:18:50 -0500" Message-ID: <86vg1ejp2u.fsf@elgar.kettenis.dyndns.org> X-SW-Source: 2002-12/txt/msg00711.txt.bz2 Daniel Jacobowitz writes: > I was working on a "set osabi" command again this morning. I got just about > everything to work with just local changes to osabi.c, until I hit a real > stumbling block: there was absolutely no way to figure out what the > _current_ OS ABI was. It was stored in the tdep struct of every > architecture that actually recognized the field. That much code duplication > tipped me off that it would probably be easier to move the enum into the > gdbarch vector; in fact, to move it into the struct gdbarch_info used to > select. Everything got much easier after that, although it was a bit > tedious - another one of those hundred-line changelogs. Yes please! Mark