From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53302 invoked by alias); 9 Jul 2015 12:47:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53292 invoked by uid 89); 9 Jul 2015 12:47:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f42.google.com Received: from mail-pa0-f42.google.com (HELO mail-pa0-f42.google.com) (209.85.220.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 09 Jul 2015 12:47:00 +0000 Received: by pacws9 with SMTP id ws9so151752143pac.0 for ; Thu, 09 Jul 2015 05:46:58 -0700 (PDT) X-Received: by 10.66.180.71 with SMTP id dm7mr31038643pac.51.1436446018646; Thu, 09 Jul 2015 05:46:58 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id md10sm5934081pdb.33.2015.07.09.05.46.56 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 09 Jul 2015 05:46:57 -0700 (PDT) From: Yao Qi To: Pierre Langlois Cc: qiyaoltc@gmail.com, gdb-patches@sourceware.org Subject: Re: [PATCH v2 4/8] [AArch64] Teach prologue unwinder to terminate gracefully References: <86pp42mxbz.fsf@gmail.com> <1436438962-2794-1-git-send-email-pierre.langlois@arm.com> Date: Thu, 09 Jul 2015 12:47:00 -0000 In-Reply-To: <1436438962-2794-1-git-send-email-pierre.langlois@arm.com> (Pierre Langlois's message of "Thu, 9 Jul 2015 11:49:22 +0100") Message-ID: <86vbdtlcqr.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00286.txt.bz2 Pierre Langlois writes: > +/* Allocate and fill in *THIS_CACHE with information about the prologue = of > + *THIS_FRAME. Do not do this is if *THIS_CACHE was already allocated. > + Return a pointer to the current aarch64_prologue_cache in *THIS_CACHE. > + */ We don't write */-only line in the comment. See "Block Comment Formatting" in https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards You can change it to ... *THIS_CACHE. */ --=20 Yao (=E9=BD=90=E5=B0=A7)