Re: [PATCH 08/18] gdbserver resume_stop handling bug

Eli Zaretskii
2015-11-25T17:53:36Z

> Date: Wed, 25 Nov 2015 15:12:26 +0000
> From: Pedro Alves <palves@redhat.com>
> CC: gdb-patches@sourceware.org
>
> >> infrun: Thread 1639.22253 executing, already stopping
> > ^^^^^^^^^^^^^^^^
> > This is bad English. Suggest to change to "already stopped".
>
> In this case, "already stopped" would be misleading, as the thread
> isn't really fully stopped yet. This is logging the process of
> stopping all threads, conveying "already in progress of being stopped".
> IOW, "Thread foo is executing, and we're already stopping it".

The problem is that this sentence makes "executing" and "stopping"
seem to refer to the same entity, which is not what you want. As you
say above: the _thread_ is executing, and _we_ are stopping it.

So if my suggestion seems too inaccurate to you (personally, I don't
think that nit will matter, but that's me), then we should rephrase
this more radically. How about

infrun: Thread 1639.22253 executing, about to stop

or

infrun: Thread 1639.22253 in process of being stopped

or even

infrun: Thread 1639.22253 was requested to stop, still didn't

Or something along these lines.

Thanks.