Re: [PATCH 14/18] Implement TARGET_WAITKIND_NO_RESUMED in the remote protocol

Eli Zaretskii
2015-10-14T16:36:39Z

> From: Pedro Alves <palves@redhat.com>
> Date: Wed, 14 Oct 2015 16:28:02 +0100
>
> gdb/ChangeLog:
> 2015-10-14 Pedro Alves <palves@redhat.com>
>
> PR 14618
> * NEWS (New remote packets): Mention the N stop reply.
> * remote.c (remote_protocol_features): Add "no-resumed" entry.
> (remote_query_supported): Report no-resumed+ support.
> (remote_parse_stop_reply): Handle 'N'.
> (process_stop_reply): Handle TARGET_WAITKIND_NO_RESUMED.
> (remote_wait_as): Handle 'N' / TARGET_WAITKIND_NO_RESUMED.
> (_initialize_remote): Register "set/show remote
> no-resumed-stop-reply" commands.
>
> gdb/doc/ChangeLog:
> 2015-10-14 Pedro Alves <palves@redhat.com>
>
> PR 14618
> * gdb.texinfo (Stop Reply Packets): Document the N stop reply.
> (Remote Configuration): Add the "set/show remote
> no-resumed-stop-reply" to the available settings table.
> (General Query Packets): Document the "no-resumed" qSupported
> feature.
>
> gdb/gdbserver/ChangeLog:
> 2015-10-14 Pedro Alves <palves@redhat.com>
>
> PR 14618
> * linux-low.c (linux_wait_1): If the last resumed thread is gone,
> report TARGET_WAITKIND_NO_RESUMED.
> * remote-utils.c (prepare_resume_reply): Handle
> TARGET_WAITKIND_NO_RESUMED.
> * server.c (report_no_resumed): New global.
> (handle_query) <qSupported>: Handle "no-resumed+". Report
> "no-resumed+" support.
> (resume): When the target reports TARGET_WAITKIND_NO_RESUMED, only
> return error if the client doesn't support no-resumed events.
> (push_stop_notification): New function.
> (handle_target_event): Use it. Report TARGET_WAITKIND_NO_RESUMED
> events if the client supports them.

OK for the documentation parts.

Thanks.