From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67701 invoked by alias); 7 Apr 2016 16:19:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67680 invoked by uid 89); 7 Apr 2016 16:19:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pf0-f182.google.com Received: from mail-pf0-f182.google.com (HELO mail-pf0-f182.google.com) (209.85.192.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 07 Apr 2016 16:19:02 +0000 Received: by mail-pf0-f182.google.com with SMTP id e128so58460145pfe.3 for ; Thu, 07 Apr 2016 09:19:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=+1lN0wOYL65tuZIQQydOrm4h+19tQVEiTjO2B9Eh9GY=; b=Z7DZN3gc3YB0pnxBYbxKmxGsNu9hfYJerC+XBKmA7Jus/wGqZGWKovU3a+ZmNHdwfE YLJk0IOe9Wk98bqVxgcwOiA0Ddl0HohBUqsH2Q4TYrMNbqvU/c7L0s0YgiSVpLHGo1ej hfySNkdBnEzNsl+pMi+mHNwAOR8fxYGwg8PZGM+8wMb8V1p7Kt0jO9lABz90s6jUiPZ1 4XhqCTgRDU0t9s2BMU+w95r055EekTlfnGSrIcAvb500z/P7Znii9ZFdCKlI9ozBzDL2 8BSUZr0yIp3DIT1+As/YAGTL5aReMREbfeoAZ1Nnme0G4w4itfbhzZp7h+uXLzYMpUU0 yQ7Q== X-Gm-Message-State: AD7BkJItPkJkuTjOS7j+oAQrl30jaqWxtqvtRn8UJhIuKwZ8aEa0oP21cckmyENj7o+pRg== X-Received: by 10.98.18.1 with SMTP id a1mr5858348pfj.39.1460045940452; Thu, 07 Apr 2016 09:19:00 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id r65sm13251670pfa.27.2016.04.07.09.18.57 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 07 Apr 2016 09:18:59 -0700 (PDT) From: Yao Qi To: Bernhard Heckel Cc: gdb-patches@sourceware.org, brobecker@adacore.com Subject: Re: [PATCH V2 1/3] fort_dyn_array: Enable dynamic member types inside a structure. References: <1459936659-19039-1-git-send-email-bernhard.heckel@intel.com> <1459936659-19039-2-git-send-email-bernhard.heckel@intel.com> Date: Thu, 07 Apr 2016 16:19:00 -0000 In-Reply-To: <1459936659-19039-2-git-send-email-bernhard.heckel@intel.com> (Bernhard Heckel's message of "Wed, 6 Apr 2016 11:57:37 +0200") Message-ID: <86vb3tl7di.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00158.txt.bz2 Bernhard Heckel writes: Hi Bernhard, Patch is good to me, two nits below, > + /* If type has a dynamic resolved location property update it's value = address. */ This line is too long. > + type =3D value_type (whole); > + if (TYPE_DATA_LOCATION (type) > + && TYPE_DATA_LOCATION_KIND (type) =3D=3D PROP_CONST) > + set_value_address (component, TYPE_DATA_LOCATION_ADDR (type)); > } >=20=20 > -=0C > /* Access to the value history. */ >=20=20 > /* Record a new value in the value history. > @@ -2416,6 +2428,12 @@ set_internalvar (struct internalvar *var, struct v= alue *val) > call error () until new_data is installed into the var->u to avoid > leaking memory. */ > release_value (new_data.value); > + > + /* Internal variables which are created from values with a dynamic= location This line is too long. > + don't need the location property of the origin anymore. > + Remove the location property in case it exist. */ > + remove_dyn_prop (DYN_PROP_DATA_LOCATION, value_type (new_data.valu= e)); --=20 Yao (=E9=BD=90=E5=B0=A7)