From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64634 invoked by alias); 25 Apr 2017 16:08:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63964 invoked by uid 89); 25 Apr 2017 16:08:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=sol, sof X-HELO: mail-wm0-f49.google.com Received: from mail-wm0-f49.google.com (HELO mail-wm0-f49.google.com) (74.125.82.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Apr 2017 16:08:17 +0000 Received: by mail-wm0-f49.google.com with SMTP id w64so27206113wma.0 for ; Tue, 25 Apr 2017 09:08:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=rW8jEGpRMKJl3PZxBDPUbQ/3DPukz8A+CxyR4JlVhiU=; b=pqrTtCi/olqb5L9MnfS2F00TjHUIBF9tjMeSRFd/DqZTVPNXnlk/UB0HgTWqGQD/EU QiBG1mqdY+CJ3wxAsTIKKgDYuLsp/tadjUHP+mJLRi4aadPC5qFluc7vUxSAbwvLqsMe pfBKmImVgQ8W2k7eUyogddDnXvizneeTsnH23NtAGp7q+bQsjJqq8WNsdVG7Mu3cZolf gmlyy/Xv/0fi7ObjSOH9cOs5AvlwbOGBEh2bfL4RelTWu6ph84m6jDscVs2tROPdXQyz OAHmF5APxL+dun5hk5B7TFk9hWa+6RzBYNIngj/tbC716fHoYFwRdGurU15YWN1bWHlX UZLg== X-Gm-Message-State: AN3rC/7HmtePve8iFT4EILyS1XbF0UUKzTRaK3009Uj20+VBhkVp0kQU AJUc8AydAEEg1URy X-Received: by 10.28.156.140 with SMTP id f134mr12742642wme.40.1493136496768; Tue, 25 Apr 2017 09:08:16 -0700 (PDT) Received: from E107787-LIN ([194.214.185.158]) by smtp.gmail.com with ESMTPSA id 133sm4981817wms.22.2017.04.25.09.08.15 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 25 Apr 2017 09:08:16 -0700 (PDT) From: Yao Qi To: Alan Hayward Cc: "gdb-patches\@sourceware.org" , Subject: Re: [PATCH 2/11] Add IA64_MAX_REGISTER_SIZE References: <8637dnqils.fsf@gmail.com> <90F5717F-8685-4C74-B2E4-7317AF228034@arm.com> <86pogivp7m.fsf@gmail.com> <0CAAE3E4-1860-40FF-895E-6C6A54A4EAB6@arm.com> Date: Tue, 25 Apr 2017 16:08:00 -0000 In-Reply-To: <0CAAE3E4-1860-40FF-895E-6C6A54A4EAB6@arm.com> (Alan Hayward's message of "Wed, 12 Apr 2017 13:41:15 +0000") Message-ID: <86vapsqxld.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00668.txt.bz2 Alan Hayward writes: > @@ -1516,8 +1519,7 @@ examine_prologue (CORE_ADDR pc, CORE_ADDR lim_pc, > else if (qp =3D=3D 0 && rN =3D=3D 2 > && ((rM =3D=3D fp_reg && fp_reg !=3D 0) || rM =3D=3D 12)) > { > - gdb_byte buf[MAX_REGISTER_SIZE]; > - CORE_ADDR saved_sp =3D 0; > + ULONGEST saved_sp =3D 0; Is it necessary to change the type of "saved_sp"? > @@ -2490,12 +2488,11 @@ ia64_access_reg (unw_addr_space_t as, unw_regnum_= t uw_regnum, unw_word_t *val, > int write, void *arg) > { > int regnum =3D ia64_uw2gdb_regnum (uw_regnum); > - unw_word_t bsp, sof, sol, cfm, psr, ip; > + ULONGEST bsp, sof, cfm, psr, ip; Why do you change the type? > struct frame_info *this_frame =3D (struct frame_info *) arg; > struct gdbarch *gdbarch =3D get_frame_arch (this_frame); > enum bfd_endian byte_order =3D gdbarch_byte_order (gdbarch); > long new_sof, old_sof; > - gdb_byte buf[MAX_REGISTER_SIZE]; > > /* We never call any libunwind routines that need to write registers. = */ > gdb_assert (!write); > @@ -2570,12 +2561,11 @@ ia64_access_rse_reg (unw_addr_space_t as, unw_reg= num_t uw_regnum, > unw_word_t *val, int write, void *arg) > { > int regnum =3D ia64_uw2gdb_regnum (uw_regnum); > - unw_word_t bsp, sof, sol, cfm, psr, ip; > + ULONGEST bsp, sof, cfm, psr, ip; Likewise. --=20 Yao (=E9=BD=90=E5=B0=A7)