From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88889 invoked by alias); 12 Jun 2017 13:57:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88745 invoked by uid 89); 12 Jun 2017 13:57:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:static. X-HELO: mail-it0-f50.google.com Received: from mail-it0-f50.google.com (HELO mail-it0-f50.google.com) (209.85.214.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Jun 2017 13:57:13 +0000 Received: by mail-it0-f50.google.com with SMTP id l6so12141751iti.1 for ; Mon, 12 Jun 2017 06:57:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=3xs1/Fr5J1Q/jjPCkhjF/AgmNy/U6rp/zxMTayf6M5g=; b=In8XCDmt0QbUzwF/ABWllzkTJAgdIgornaVz5hlCcjLrsEn769QQWbW/cjTZ0/57j1 LlfDo4USs3Xhq5qunIr99p7Sxt++1Fuq1nEUIAbVrY5a1zuNSYabGq+b46kFeFkeAP55 vBoS0YT25ibW/96nKw+rq4bmNsMLxVdbaYaKwoARzfYupOIGZCs4Tf9C3/TsB4nh+h8x 3AzWyV1keNF+B14nHzYXx3aGGzBRvUvmSPws4dh/2Fr60bvWwwS1vEVJ976rtxNYSMsR DwLqAbLTWSJk2jRxans6A6N31soCJI24jmLC9LUp6xaS+kdgnm3iNmj7TpfHGMt/x2RD /Y/A== X-Gm-Message-State: AODbwcBBJ7+e6efB098/oTA3/dIMOXelAgxrVSnTJqhyOmXTkUKDaXDR gnhy/goeUffG3Vxk X-Received: by 10.36.101.135 with SMTP id u129mr12249919itb.21.1497275836477; Mon, 12 Jun 2017 06:57:16 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id b6sm4757219ioa.15.2017.06.12.06.57.15 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 12 Jun 2017 06:57:16 -0700 (PDT) From: Yao Qi To: Andreas Arnez Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 19/19] read/write_pieced_value: Merge into one function References: <1494352015-10465-1-git-send-email-arnez@linux.vnet.ibm.com> <1494352015-10465-20-git-send-email-arnez@linux.vnet.ibm.com> Date: Mon, 12 Jun 2017 13:57:00 -0000 In-Reply-To: <1494352015-10465-20-git-send-email-arnez@linux.vnet.ibm.com> (Andreas Arnez's message of "Tue, 9 May 2017 19:46:15 +0200") Message-ID: <86vao18g1y.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00310.txt.bz2 Andreas Arnez writes: > + if (from =3D=3D NULL) > + { > + /* Read mode. */ > + read_value_memory (v, offset, > + p->v.mem.in_stack_memory, > + p->v.mem.addr + bits_to_skip / 8, > + buffer.data (), this_size); > + copy_bitwise (v_contents, offset, > + buffer.data (), bits_to_skip % 8, > + this_size_bits, bits_big_endian); > + break; > + } > + > + /* Write mode. */ I feel it is more clear to add "else" here, like if (from =3D=3D NULL) { /* Read mode. */ } else { /* Write mode. */ } then, we don't need the "break" above. > + if (bits_to_skip % 8 !=3D 0 || this_size_bits % 8 !=3D 0) > + { > + if (this_size <=3D 8) > + { > + /* Perform a single read for small sizes. */ > + read_memory (start_addr, buffer.data (), this_size); > + } > + else > + { > + /* Only the first and last bytes can possibly have any > + bits reused. */ > + read_memory (start_addr, buffer.data (), 1); > + read_memory (start_addr + this_size - 1, > + &buffer[this_size - 1], 1); > + } > + } > + > + copy_bitwise (buffer.data (), bits_to_skip % 8, > + from_contents, offset, > + this_size_bits, bits_big_endian); > + write_memory_with_notification (start_addr, buffer.data (), > + this_size); > + } > break; Otherwise, the patch is good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)