Re: [PATCH 2/2] gdb: Make some test names unique

Pedro Alves
2017-06-22T12:12:41Z

On 06/14/2017 07:57 PM, Andrew Burgess wrote:
> @@ -95,7 +95,7 @@ mi_run_cmd
> mi_expect_stop "breakpoint-hit" "vla" "" ".*vla.f90" "$bp_lineno" \
> { "" "disp=\"del\"" } "run to breakpoint at line $bp_lineno"
> mi_gdb_test "520-data-evaluate-expression vla1" \
> - "520\\^done,value=\"\\(1, 1, 1, 1, 1\\)\"" "evaluate filled vla"
> + "520\\^done,value=\"\\(1, 1, 1, 1, 1\\)\"" "evaluate filled vla at line $bp_lineno"
>

As principle, please avoid putting line numbers in test names. This
causes test names to spuriously change if/when the source file changes.

Thanks,
Pedro Alves