Re: [PATCH 2/2] gdb: Make some test names unique

Yao Qi
2017-06-22T10:37:50Z

Andrew Burgess <andrew.burgess@embecosm.com> writes:

> mi_gdb_test "540-data-evaluate-expression vla1(1)" \
> - "540\\^done,value=\"1\"" "evaluate filled vla"
> + "540\\^done,value=\"1\"" "evaluate filled vla(1)"

Do not use "tail parentheses" on the test message,
https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Do_not_use_.22tail_parentheses.22_on_test_messages

Maybe ""evaluate filled vla1 1"?

> mi_gdb_test "550-data-evaluate-expression vla1(2)" \
> - "550\\^done,value=\"42\"" "evaluate filled vla"
> + "550\\^done,value=\"42\"" "evaluate filled vla(2)"
> mi_gdb_test "560-data-evaluate-expression vla1(4)" \
> - "560\\^done,value=\"24\"" "evaluate filled vla"
> + "560\\^done,value=\"24\"" "evaluate filled vla(4)"

Otherwise, patch is good to me.

--
Yao (齐尧)