Re: [PATCHv2 2/2] gdb: Make some test names unique

Pedro Alves
2017-07-13T22:40:46Z

On 07/13/2017 09:15 PM, Andrew Burgess wrote:
> Thanks for the review and feedback. I've taken on-board what you both
> said, and I have a new patch which I think should be fine, in this I:
>
> - Add '(...text...)' at the end, but only _without_ a space before
> the '('.
>
> - I no longer use line numbers to make test names unique, instead I
> use more descriptive text.
>
> - I've not changed the names of any tests that were already unique,
> even if those names included a line number.
>
> OK to apply?

OK.

Though I'd think avoiding ()s entirely in the cases that the
()s are not part of the expression would be less surprising,
like e.g.:

-"evaluate filled vla(contents modified)"
+"evaluate filled vla, contents modified"

OK with that change too.

Thanks,
Pedro Alves