From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44564 invoked by alias); 22 Jun 2017 10:37:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44541 invoked by uid 89); 22 Jun 2017 10:37:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:828, H*r:sk:static. X-HELO: mail-it0-f46.google.com Received: from mail-it0-f46.google.com (HELO mail-it0-f46.google.com) (209.85.214.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Jun 2017 10:37:47 +0000 Received: by mail-it0-f46.google.com with SMTP id m47so18367463iti.0 for ; Thu, 22 Jun 2017 03:37:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=jFVKriuf3SrbprOvGq6hEytp0+s7jV3FpTt0BSeqMfg=; b=Ck5Qzus9fUxA/PuFpmj0H1WQmiy6Cy3Kp751sRS/3hTAwf7U6lYRnha7mkrdzks2fo PoFn55Zrqoj7szpf49OiK/Nl7jMs2abRl5YKXglKLC6f4UfTHXmbK/FSGwZtk+YJNbKX FNtJyu4H1SBOBT1u3JOwFleQJ1lfYx9SfbB/70DxWZ/cdIOKgSmbPxIqMbyxkiuWIxy6 RqjnZOmdTlIuTjv/SbAoth6eQukX1MqqP9XoQ5agyzd+GBmSSOS1hwP7V+i21rBAiVqS ChRI7exOu8lJTa7Rpa93bnZGTZTHGifMQ0pOCN0WIMcakDXyy0fAyaOecbyYHB5Pr8p+ AnFw== X-Gm-Message-State: AKS2vOzZE6N+Bw/uuCnbjQFsvkTQOoeFvO3VZICAxgnTKEPdhOJd7VtZ aMlBggJ4JeYIWIk4 X-Received: by 10.36.65.18 with SMTP id x18mr1301569ita.88.1498127865856; Thu, 22 Jun 2017 03:37:45 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id n73sm726567itb.13.2017.06.22.03.37.34 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 22 Jun 2017 03:37:35 -0700 (PDT) From: Yao Qi To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] gdb: Make some test names unique References: Date: Thu, 22 Jun 2017 10:37:00 -0000 In-Reply-To: (Andrew Burgess's message of "Wed, 14 Jun 2017 19:57:39 +0100") Message-ID: <86vanoi9zm.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00632.txt.bz2 Andrew Burgess writes: > mi_gdb_test "540-data-evaluate-expression vla1(1)" \ > - "540\\^done,value=3D\"1\"" "evaluate filled vla" > + "540\\^done,value=3D\"1\"" "evaluate filled vla(1)" Do not use "tail parentheses" on the test message, https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Do_not_use_.22tail_pare= ntheses.22_on_test_messages Maybe ""evaluate filled vla1 1"? > mi_gdb_test "550-data-evaluate-expression vla1(2)" \ > - "550\\^done,value=3D\"42\"" "evaluate filled vla" > + "550\\^done,value=3D\"42\"" "evaluate filled vla(2)" > mi_gdb_test "560-data-evaluate-expression vla1(4)" \ > - "560\\^done,value=3D\"24\"" "evaluate filled vla" > + "560\\^done,value=3D\"24\"" "evaluate filled vla(4)" Otherwise, patch is good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)