From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85582 invoked by alias); 2 Nov 2017 10:02:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84286 invoked by uid 89); 2 Nov 2017 10:02:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*Ad:D*ca, H*r:sk:static. X-HELO: mail-wm0-f41.google.com Received: from mail-wm0-f41.google.com (HELO mail-wm0-f41.google.com) (74.125.82.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 02 Nov 2017 10:02:09 +0000 Received: by mail-wm0-f41.google.com with SMTP id m72so1737497wmc.0 for ; Thu, 02 Nov 2017 03:02:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=3EW8iE62Smdn0t1RRZIVXD7My79wJPLTvlxjSesUan8=; b=nk6ei9aTnhe4E0l8izCV+0/HA2oCiI6G1i2raRohSxhRxfTTVA1uLMsDnp5OXGLboc VZDiOr6oHsrfnmE1dIMdreRpjN5S4EGN71UwUUlD4xqUehM86c2JA903XarZwtH9wpxl +1MK8peqwcdEtyGjgbRMy0WjrePZ4owBIb4hYa03EQrQV9sdlK1OJno/U02sVPWdf89x SZsKs+h8wKYNRa+wX1Kqz5KbAPRfAdZJDnQZFPVyFBrL4zT96broCbvqgAFXfUK7M6Qc SpjLozwPnTMbzpNQwCPZrwnPp6bVthHX0IfKAcGfvduR9jZ78wzLHK6XYi/SEDi83onH DwhQ== X-Gm-Message-State: AMCzsaXqT51TiVUpHnJHF6pLzU1YR5lgguYwoDA9SdWsnwTUWzf/gwqL 0Wa4ABQYbteRBmxLRzW+3AY= X-Google-Smtp-Source: ABhQp+ROJv6juheFTxtG0oBwH6DgRPW0O1TpWXS6Niz7RjNbbhacNqa4bw2SI8Gh5RalZs2eXVV5pg== X-Received: by 10.28.105.142 with SMTP id z14mr1206054wmh.41.1509616927539; Thu, 02 Nov 2017 03:02:07 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id v5sm1844150wrf.29.2017.11.02.03.02.06 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 02 Nov 2017 03:02:07 -0700 (PDT) From: Yao Qi To: Simon Marchi Cc: , Simon Marchi Subject: Re: [PATCH 09/10] Make tdesc_type::u::u::fields an std::vector References: <1509414120-14659-1-git-send-email-simon.marchi@ericsson.com> <1509414120-14659-10-git-send-email-simon.marchi@ericsson.com> Date: Thu, 02 Nov 2017 10:02:00 -0000 In-Reply-To: <1509414120-14659-10-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Mon, 30 Oct 2017 21:41:59 -0400") Message-ID: <86vaitvw0z.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00024.txt.bz2 Simon Marchi writes: > This patch makes the tdesc_type::u::u::fields an std::vector of > tdesc_type_field. The difficulty here is that the vector is part of a > union. Because of this, I made fields a pointer to a vector, and > instantiate/destroy the vector if the type is one that uses this member > of the union Hi Simon, Did you consider remove that union by sub-class tdesc_type. We can add to new sub-classes, tdesc_type_with_fields and tdesc_type_vector, for example? --=20 Yao (=E9=BD=90=E5=B0=A7)