Re: [PATCH v2 5/8] Use tdesc types in gdbserver tdesc

Alan Hayward
2018-01-29T15:52:51Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1077 bytes --]

> On 29 Jan 2018, at 11:30, Philipp Rudo <prudo@linux.vnet.ibm.com> wrote:
>
> Hi Alan,
>
>
> On Mon, 29 Jan 2018 11:01:25 +0000
> Alan Hayward <Alan.Hayward@arm.com> wrote:
>
>>>
>>> With tdesc_features, tdesc_type_with_fields etc. being no longer opaque and
>>> so many functions shared many of them could be made class methods. However
>>> that exceeds the scope of this patch set, but should be kept in mind for the
>>> future.
>>
>> The "[PATCH] Use visitors for make_gdb_typeâ€ patch should take care of a large set of them.
>
> I was more thinking of functions like tdesc_add_* and tdesc_create_* (including
> tdesc_create_reg). They are not covered by your make_gdb_type patch. The way
> I see it the changes needed to be made are quite small. Unfortunately they
> require to regenerate the cfiles making the resulting patches large and hard
> to read.
>

Ok, happy to look at these in a follow on patch. Should be simple enough to write the patch,
just a little messy to review.

Alan.

\x16º&Öéj×!zÊÞ¶êç×ŽuÛYb²Ö«r\x18\x1dn–­r\x17¬