Re: [PATCH v2 0/8] Remove XML files from gdbserver

Alan Hayward
2018-01-24T18:53:14Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1686 bytes --]

> On 24 Jan 2018, at 14:43, Omair Javaid <omair.javaid@linaro.org> wrote:
>
> Were you having trouble with a particular patch or was it all of them?
> Also, how are you getting the patch email from your email client to git?
>
> I downloaded eml files. Also tried with untouched orignal email text. First 2 patches are applicable using git am. Third patch and onwards fail.
>
> With git apply or patch command even first patch fails.

Testing this, I also get the same error with patch 3, when copying from the sent email.

>
>
> I’m sending mails by opening my mail client, writing my comments, then copy/pasting the contents
> of a diff downloaded from a local reviewboard. That diff looks identical to a git format-patch or git diff.
> I’ve tried applying the first patch of the series to the latest head using both my patch file and contents
> of the email, and both work for me.
>
> I am not sure what exactly could be wrong but it could be email client mangling patch email or wrapping text or converting tabs/spaces.
>
> I think you are using a windows based email client which is using CR+LF as end line character which is incompatible with unix LF.
>

Looking at the patch, my mail client is stripping out the FF character!
Fixing this causes the patch to apply cleanly.

I’m using Mac mail. I stopped using Outlook for Mac because of similar issues.
I will investigate getting git send-email working and/or move to a new client - but that might take time.

I hope the existing emails with the remotes/origin/users/ahayward/xml branch provide everything you
need for a review.

Alan.

\x16º&Öéj×!zÊÞ¶êç×Žt×‰b²Ö«r\x18\x1dn–­r\x17¬