Re: [PATCH v6 05/10] gdb: Skip trampoline functions for the finish and reverse-finish commands.

[Eli Zaretskii <eliz@gnu.org>]

> From: Abdul Basit Ijaz <abdul.b.ijaz@intel.com>
> Cc: abdul.b.ijaz@intel.com,
> 	JiniSusan.George@amd.com,
> 	tom@tromey.com,
> 	eliz@gnu.org
> Date: Thu, 28 Mar 2024 13:05:23 +0100
> 
>  gdb/NEWS                                      |  5 +-
>  gdb/doc/gdb.texinfo                           |  4 ++
>  gdb/infcmd.c                                  | 12 ++++
>  gdb/infrun.c                                  |  8 +++
>  gdb/infrun.h                                  |  5 ++
>  gdb/testsuite/gdb.fortran/func-trampoline.exp | 13 ++++-
>  .../gdb.reverse/finish-reverse-trampoline.exp | 56 +++++++++++++++++++
>  7 files changed, 99 insertions(+), 4 deletions(-)
>  create mode 100644 gdb/testsuite/gdb.reverse/finish-reverse-trampoline.exp
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index 025f2e1a17e..b8577c58af7 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -898,8 +898,9 @@ show skip-trampoline-functions
>    recognize function calls that have been marked as trampolines in the debug
>    info.  It improves stepping behavior in that it steps over the trampoline
>    code and hides it from the user.  It improves the printing of the stack by
> -  hiding trampoline functions from the backtrace.  Currently, only DWARF
> -  trampolines are supported.
> +  hiding the trampoline frames from the backtrace and skips trampoline
> +  functions while returning from the target function of a trampoline call.
> +  Currently, only DWARF trampolines are supported.
>  
>    If this is turned off, GDB gdb will handle trampoline functions the same
>    as any other function.
> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 6117f6e889f..5782e06b91d 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -6475,6 +6475,10 @@ DWARF trampolines marked via DW_AT_trampoline are supported by this.
>  When issuing a @code{backtrace}, if @code{skip-trampoline-functions} is set,
>  @value{GDBN} will skip trampoline frames while printing the stack.
>  
> +When issuing a @code{finish} or @code{reverse-finish}, if
> +@code{skip-trampoline-functions} is set, @value{GDBN} will skip trampoline
> +frames while returning from the target function.
> +
>  Currently, only DWARF trampolines marked via DW_AT_trampoline are supported by
>  this.

Thanks, the documentation parts of this are okay.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>