From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92891 invoked by alias); 1 Jun 2015 11:35:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92873 invoked by uid 89); 1 Jun 2015 11:35:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f171.google.com Received: from mail-pd0-f171.google.com (HELO mail-pd0-f171.google.com) (209.85.192.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 01 Jun 2015 11:35:12 +0000 Received: by pdbki1 with SMTP id ki1so105771489pdb.1 for ; Mon, 01 Jun 2015 04:35:10 -0700 (PDT) X-Received: by 10.70.88.145 with SMTP id bg17mr40087774pdb.167.1433158510149; Mon, 01 Jun 2015 04:35:10 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by mx.google.com with ESMTPSA id do16sm14288447pac.15.2015.06.01.04.35.07 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 01 Jun 2015 04:35:08 -0700 (PDT) From: Yao Qi To: Jan Kratochvil Cc: Yao Qi , Andreas Schwab , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix wrong assertions References: <87vbg1eg08.fsf@igel.home> <20150513140106.GB3023@host1.jankratochvil.net> <86bnh3pw61.fsf@gmail.com> <20150529113101.GA15460@host1.jankratochvil.net> <86382fpki0.fsf@gmail.com> <20150529141027.GA8159@host1.jankratochvil.net> Date: Mon, 01 Jun 2015 11:35:00 -0000 In-Reply-To: <20150529141027.GA8159@host1.jankratochvil.net> (Jan Kratochvil's message of "Fri, 29 May 2015 16:10:27 +0200") Message-ID: <86twuroe55.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00001.txt.bz2 Jan Kratochvil writes: > diff --git a/gdb/dwarf2loc.c b/gdb/dwarf2loc.c > index 3aa8ddd..68d6cb4 100644 > --- a/gdb/dwarf2loc.c > +++ b/gdb/dwarf2loc.c > @@ -825,9 +825,9 @@ chain_candidate (struct gdbarch *gdbarch, struct call= _site_chain **resultp, >=20=20 > /* See call_site_find_chain_1 why there is no way to reach the bottom = callee > PC again. In such case there must be two different code paths to r= each > - it, therefore some of the former determined intermediate PCs must d= iffer > - and the unambiguous chain gets shortened. */ > - gdb_assert (result->callers + result->callees < result->length); > + it. Still it may CALLERS+CALLEES=3D=3DLENGTH in the case of option= al > + tail-call calling itself. */ > + gdb_assert (result->callers + result->callees <=3D result->length); I am not a native English speaker, but I can't parse the comment. How about "CALLERS + CALLEES equal to LENGTH in the case of self tail-call"? Otherwise, the patch is OK to me. --=20 Yao (=E9=BD=90=E5=B0=A7)