From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13924 invoked by alias); 12 May 2016 16:38:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13875 invoked by uid 89); 12 May 2016 16:38:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pa0-f47.google.com Received: from mail-pa0-f47.google.com (HELO mail-pa0-f47.google.com) (209.85.220.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 12 May 2016 16:38:39 +0000 Received: by mail-pa0-f47.google.com with SMTP id bt5so30766820pac.3 for ; Thu, 12 May 2016 09:38:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=WNftISNhTZfbSci9yXFboIC9khwM22kvW9dz+RU25fY=; b=kySPgpYH8qyFDKt+N4nh2ouENL8n3pi0yB6PFN1GAflum5sJmOgARC4iiCk6NDXcH+ QWKrr5kZrwaqJpk3CJsp9cFP2H2/q70EDgjfpI5Yc8UG4fop99C9Gh2qP5MN8uSVK++I cduxIGHVZd5TMMgDv2hxIntK93vii2tqf0TQSOp2OSFXgzflQxITt1bMiSVB4SRo81Sw ieh7TEw45NDTDyaNzb4Q/q/4KaEt4ffDwo2sAUgb0IZZGJwPeUfuemkgKjbqTPjt0OyB u73+yrlfsFv7a/+Pix3S5YzvBzmW5Z0bVb3M23ZGCsIRTejJml2WINGHe9FQXRTJUH2U PiXQ== X-Gm-Message-State: AOPr4FX65S2vpWVzoT5HqqIsSv0piEu5GB4GQHg4ztEkiLpWPxVEXbo597jblvOF7RtioQ== X-Received: by 10.66.153.174 with SMTP id vh14mr15484049pab.131.1463071117408; Thu, 12 May 2016 09:38:37 -0700 (PDT) Received: from E107787-LIN (gcc113.osuosl.org. [140.211.9.71]) by smtp.gmail.com with ESMTPSA id o6sm21027355pfo.64.2016.05.12.09.38.34 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 12 May 2016 09:38:35 -0700 (PDT) From: Yao Qi To: Antoine Tremblay Cc: Yao Qi , Subject: Re: [RFC 2/3] use reinsert breakpoint for vCont;s References: <1462530736-25117-1-git-send-email-yao.qi@linaro.org> <1462530736-25117-3-git-send-email-yao.qi@linaro.org> <8660ukev20.fsf@gmail.com> Date: Thu, 12 May 2016 16:38:00 -0000 In-Reply-To: (Antoine Tremblay's message of "Thu, 12 May 2016 10:03:33 -0400") Message-ID: <86twi3b5a1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00206.txt.bz2 Antoine Tremblay writes: > I though we would have to explicitly stop the threads, I'm curious has > to where you moved it so that the threads are stopped ? I moved the code deleting reinsert breakpoint to the place where GDBserver is ready to report a stop back to GDB, because on this point, all threads stop in all-stop mode, and the event thread stops in no-stop mode. In non-stop mode, I delete the reinsert breakpoint of event thread, while in all-stop mode, I delete the reinsert breakpoint of all threads. You are right that it is unsafe to remove reinsert breakpoint while some threads are still running (in non-stop mode). --=20 Yao (=E9=BD=90=E5=B0=A7)