From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31346 invoked by alias); 19 Aug 2016 09:59:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31327 invoked by uid 89); 19 Aug 2016 09:59:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:209.85.220.65, H*RU:209.85.220.65 X-HELO: mail-pa0-f65.google.com Received: from mail-pa0-f65.google.com (HELO mail-pa0-f65.google.com) (209.85.220.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Aug 2016 09:59:28 +0000 Received: by mail-pa0-f65.google.com with SMTP id vy10so3226764pac.0 for ; Fri, 19 Aug 2016 02:59:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=CyNt+cdSzdWRt6ZSKHdsedwXXQwq3ZZHb02vK0zQcJQ=; b=Dre+Tpox+6GAEQcUSrZCW12QssOZ/kNyPNg/XBWnmZ12DqCrXiZCTvyu2MTTiyhEGQ 0IFU8SsCOua8F9iDLzdQyryyJxzcGsdz6IR7JwUL4Iy3ZtKCVFBMC8FmYzQv+5A1lvfK 9BDYvREAYUxspSyLU3qDd24hX6OqA2Ess0rb8Jk4N2pUIiZ5SwQWP8TkTaUCUT1sro2R E+9LgEaKHZY7y8Y30fuzWyH6pLvpH7zNE8F1c9gPLokeANAbMQLz+SJ2Os3rNDq16yF5 K24N/F/VyPuKWIXNLzMjy6hPBMZzgsHW/YW7F8eqQr/6cvtwQkchPNrNNgKLQcrVhtGd 0XAQ== X-Gm-Message-State: AEkoousqjJaokV3du6vrzBghawiWEeI7wBZlfMyTR1UJEkk3l/lc5fMsHTewd9jTB672CA== X-Received: by 10.66.253.101 with SMTP id zz5mr12127361pac.32.1471600766826; Fri, 19 Aug 2016 02:59:26 -0700 (PDT) Received: from E107787-LIN (gcc115.osuosl.org. [140.211.9.73]) by smtp.gmail.com with ESMTPSA id t7sm10099544paz.21.2016.08.19.02.59.24 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 19 Aug 2016 02:59:26 -0700 (PDT) From: Yao Qi To: Pedro Alves Cc: Yao Qi , gdb-patches@sourceware.org Subject: Re: warning: Could not load shared library symbols for linux-vdso.so.1. References: <86twercyuv.fsf@gmail.com> <89b5bdc8-0be2-538e-3932-1f5d4a1bc1e8@redhat.com> <86eg5ucmcv.fsf@gmail.com> <96141d5a-3384-8314-1274-d1348dafe0c5@redhat.com> Date: Fri, 19 Aug 2016 09:59:00 -0000 In-Reply-To: <96141d5a-3384-8314-1274-d1348dafe0c5@redhat.com> (Pedro Alves's message of "Fri, 19 Aug 2016 02:04:59 +0100") Message-ID: <86twehaxl3.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-08/txt/msg00195.txt.bz2 Pedro Alves writes: > So I bit the bullet and made a custom Linux-specific > struct solib_ops that inherits svr4_so_ops, and overrides a couple > methods for vDSO awareness. I think the end result is clearer > and probably more extensible if/when we decide to do the work necessary > to be able to show the vdso in "info sharedlibrary", without causing > could-not-find-file warnings. > > I'm attaching two patches; the first implements the new solib_ops > instance, and then the second uses the vDSO's bfd size, fixing the > bug. > > Passes testing on x86_64 Fedora 23 here, as well as the new test. > > Let me know what you think. They are good to me. Do you plan to push them to 7.12 branch? I'd like to keep these patches in master only, because the problem they fix is minor while the patches are not small changes. What do you think? --=20 Yao (=E9=BD=90=E5=B0=A7)