Re: [PATCH 4/9] Remove addr_size field from struct piece_closure

Simon Marchi
2017-04-14T03:39:01Z

On 2017-04-13 05:10, Yao Qi wrote:
> Andreas Arnez <arnez@linux.vnet.ibm.com> writes:
>
>> The addr_size field in the piece_closure data structure is a relic
>> from
>> before introducing the typed DWARF stack. It is obsolete now. This
>> patch
>> removes it.
>>
>> gdb/ChangeLog:
>>
>> * dwarf2loc.c (struct piece_closure) <addr_size>: Remove field.
>> (allocate_piece_closure): Drop addr_size parameter.
>> (dwarf2_evaluate_loc_desc_full): Adjust call to
>> allocate_piece_closure.
>
> LGTM.

Since you are planning on making a v2, I think it's better if you check
it in right now to get it out of the way (it could be obvious anyway).

Simon