Re: [PATCH 3/9] PR gdb/21226: Take DWARF stack value pieces from LSB end

Simon Marchi
2017-04-18T16:43:39Z

On 2017-04-18 12:31, Andreas Arnez wrote:
>> It would be really nice for the readers if you could put some comment
>> like
>> this, even though it may seem obvious to you:
>>
>> /* The size of a DWARF stack value. */
>> ULONGEST obj_size = 8 * TYPE_LENGTH (value_type (p->v.value));
>>
>> I found I had to add them to the code to be able to follow.
>
> OK, but it seems that the variable name 'obj_size' causes the
> confusion;
> so I'd rather skip the comment, change the variable name to
> stack_value_size_bits instead and let it speak for itself.

I agree.

Thanks,

Simon