Re: [PATCH 1/9] Add test for modifiable DWARF locations

Andreas Arnez
2017-04-13T10:52:34Z

On Thu, Apr 13 2017, Simon Marchi wrote:

> To be honest, I didn't know what a DWARF piece was before, well, two hours
> ago. I've spent some time reading about that, including your write-up on
> the problem [1] (very informative, thanks) and the implementation of
> read_pieced_value. I can't say I have a very good grasp on the problem
> you are tackling, but I got enough to understand all the lines in this
> patch, and it looks good to me.

Thanks for your interest in this topic; very much appreciated. The more
people look at this, the better our chance of getting it right this
time.

> It will probably take someone with more experience about this stuff than
> me to review the more intricate parts of the series, but I'll keep on
> reading when I have time, even if it's just for my own knowledge/enjoyment
> :). Although while going through read_pieced_value line by line, I've
> found some areas that could be improved. I suspect that there might be
> some overlap with some of the following patches of your series, so I might
> be able to understand and review those.

Yeah, the follow-up patches rewrite most of read/write_pieced_value.

--
Andreas