From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88598 invoked by alias); 21 Apr 2017 15:21:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88555 invoked by uid 89); 21 Apr 2017 15:21:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*RU:74.125.82.65, Hx-spam-relays-external:74.125.82.65 X-HELO: mail-wm0-f65.google.com Received: from mail-wm0-f65.google.com (HELO mail-wm0-f65.google.com) (74.125.82.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Apr 2017 15:21:52 +0000 Received: by mail-wm0-f65.google.com with SMTP id o81so5481969wmb.0 for ; Fri, 21 Apr 2017 08:21:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=6WN8Oh1i/drMV1ajyUHolKYr8fKf2DtmLwRgxdF8eR4=; b=GQSSai6xh4VtkDzF9YC/liplbQFhj9o2K1/r5zN9slAaJif8CTWW5Ou+N3ofTMyEnI wGlr+81L3lTHci9cSr1s5YzsDCY4rtasNAXOESI7vck3i/pqgTnZouEQDmE80pEh+zdY RKxkZXgem6fGRlO4r9DB3DN/rzRJEbZDH4MaHbZJBomSrS6NAYuN6GFYZlInPRD5yuVV FjJXKUn6bebsCfxvUBBbd3FPACX3wnIA4FuuIC39RyYeSW41zW58S7xoB/buKeos7dUu gm86FxQvIxqFRfTRCBj5eaEaL30EPqtgTRClWtvUJUHsCsuPI4HVSBZYM0he0je+s1A9 TumQ== X-Gm-Message-State: AN3rC/7hDYsBOC0zyHvfNR90Th08731ZnSZKU+ktAjd91aAo3stHICGH mrGleLJMOaO7dZj2 X-Received: by 10.28.49.136 with SMTP id x130mr8202895wmx.137.1492786372615; Fri, 21 Apr 2017 07:52:52 -0700 (PDT) Received: from E107787-LIN ([194.214.185.158]) by smtp.gmail.com with ESMTPSA id u23sm2268810wmu.16.2017.04.21.07.52.51 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 21 Apr 2017 07:52:52 -0700 (PDT) From: Yao Qi To: Tim Wiederhake Cc: gdb-patches@sourceware.org, markus.t.metzger@intel.com, brobecker@adacore.com Subject: Re: [PATCH v2 6/8] Python: Move and rename gdb.BtraceInstruction References: <1492771786-26372-1-git-send-email-tim.wiederhake@intel.com> <1492771786-26372-7-git-send-email-tim.wiederhake@intel.com> Date: Fri, 21 Apr 2017 15:21:00 -0000 In-Reply-To: <1492771786-26372-7-git-send-email-tim.wiederhake@intel.com> (Tim Wiederhake's message of "Fri, 21 Apr 2017 12:49:44 +0200") Message-ID: <86tw5hzubi.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00613.txt.bz2 Tim Wiederhake writes: > 2017-04-21 Tim Wiederhake > > gdb/ChangeLog: > * python/py-record-btrace.c (BTPY_REQUIRE_VALID_INSN): Remove. > (btpy_object, btpy_insn_type, btpy_new): Remove. > (btpy_list_object): Use gdb.RecordInstruction type instead of > gdb.BtraceInstruction type. > (btrace_insn_from_recpy_insn): New function. > (btpy_insn_or_gap_new): Adjust comment. Use recpy_insn_new instead of > btpy_new. > (btpy_call_new, btpy_list_item): Do not use btpy_new anymore. > (btpy_number, btpy_hash, btpy_call_level, btpy_call_symbol, > btpy_call_instructions, btpy_call_up, btpy_call_prev_sibling, > btpy_call_next_sibling, btpy_richcompare): Use recpy_element_object > instead of btpy_object. > (btpy_insn_sal, btpy_insn_pc, btpy_insn_size, btpy_insn_is_speculative, > btpy_insn_data, btpy_insn_decode): Rename to ... > (recpy_bt_insn_sal, recpy_bt_insn_pc, recpy_bt_insn_size, > recpy_bt_insn_is_speculative, recpy_bt_insn_data, > recpy_bt_insn_decode): This. Also, use new helper functions. > (btpy_list_position, recpy_bt_goto): Use recpy_element_object and > recpy_insn_type. > (btpy_insn_getset): Remove. > (gdbpy_initialize_btrace): Remove code to initialize > gdb.BtraceInstruction. Use recpy_element_object. > * python/py-record-btrace.h (recpy_bt_insn_number, recpy_bt_insn_sal, > recpy_bt_insn_pc, recpy_bt_insn_data, recpy_bt_insn_decoded, > recpy_bt_insn_size, recpy_bt_insn_is_speculative): New export. > * python/py-record.c (recpy_insn_type): New static object. > (recpy_insn_new, recpy_insn_sal, recpy_insn_pc, recpy_insn_data, > recpy_insn_decoded, recpy_insn_size, recpy_insn_is_speculative, > recpy_element_number, recpy_element_hash, recpy_element_richcompare): > New function. > (recpy_insn_getset): New static object. > (gdbpy_initialize_record): Initialize gdb.RecordInstruction. > * python/py-record.h (recpy_element_object): New typedef. > (recpy_insn_type, recpy_insn_new): New export. Patch is good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)