From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id TP3zD6qfjGapNyAAWB0awg (envelope-from ) for ; Mon, 08 Jul 2024 22:25:46 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=kgxp534S; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2CB331E0C3; Mon, 8 Jul 2024 22:25:46 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1A0011E030 for ; Mon, 8 Jul 2024 22:25:43 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 50ED4384A459 for ; Tue, 9 Jul 2024 02:25:42 +0000 (GMT) Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 267403858D35 for ; Tue, 9 Jul 2024 02:25:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 267403858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 267403858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1720491923; cv=none; b=LqTs/UIX1dyH5Bg8bVvHk4eph7LA59OrN7RRfmim/KB1ng1TgkMywo1gq4+4Dtk6MnichBcyF4E+3mwv8bLi/EF9Rfjs0H4Law0QynAWhukh0ggj9J0jruUz/pHsQzfpqRCEGA1btTyv+1J5TkQdvjsJpm+jiksma/4QlL0XWkQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1720491923; c=relaxed/simple; bh=xSwMqUy8ECSMYvJhM6ALdb1/wdtEMczqTRl50mzEd2A=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=CKdE6xHCVi7hDT3/rjc0N6u/wtUaf7H5UCxYW+qQgzeqMVUqqjSuEqc7B5mSm0MNt2aCGaAf3I1ci/ndAldxBccVSc4Xs/Ds3gKegn/xn3JG9/WOaC/tiA7gflnGFMy7Mont7YIn9xk7r5VLg1AapfjySOTaUC4DHLWbcDUcOzQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sR0Xh-0008Tb-DV; Mon, 08 Jul 2024 22:25:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=eWvw9TCK+HTWE5V7lTVRZmCxjOiOD6jgyD3LrcIbbJU=; b=kgxp534SllGF BTB3uPcuszTmf3BfLQqsa7FLWIdxezX//jb+5/9QcfiXQlGEtsD8+1G2VzlRKG8oPF2ZMxJOV6sJn bo7kb9DZY6thVjH9gPA2Jckb2fzAX2AzP8fKGlSivzxKTWh3L9qyzWIcxwlCVK2MZMtEsYXUF5D8Q Qi/lubP4Gmae+g4dAcU1Ni67FOaaQSXzqJKQ47pfLJlO0GJ9dkBht4RT0CNpE0hHJi8o/scwGRUlV y8g8k0UP+wBmwXoom1LFRLL7Ch0lyShaIUChb4TyJl049oC921OFRTvu6sF8K2LUx+GHnagXnunby 8vxnx2S9gw21dc3IPFzrjA==; Date: Tue, 09 Jul 2024 05:25:16 +0300 Message-Id: <86ttgzz4hf.fsf@gnu.org> From: Eli Zaretskii To: Alex Chronopoulos Cc: gdb-patches@sourceware.org In-Reply-To: <20240708192730.264313-1-achronop@gmail.com> (message from Alex Chronopoulos on Mon, 8 Jul 2024 21:27:30 +0200) Subject: Re: [PATCH v5] Change message when reaching end of reverse history. References: <20240708192730.264313-1-achronop@gmail.com> X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > From: Alex Chronopoulos > Cc: Alex Chronopoulos > Date: Mon, 8 Jul 2024 21:27:30 +0200 > > In a record session, when we move backward, GDB switches from normal > execution to simulation. Moving forward again, the emulation continues > until the end of the reverse history. When the end is reached, the > execution stops, and a warning message is shown. This message has been > modified to indicate that the forward emulation has reached the end, but > the execution can continue as normal, and the recording will also continue. > > Before this patch, the warning message shown in that case was the same as > in the reverse case. This meant that when the end of history was reached in > either backward or forward emulation, the same message was displayed: > > "No more reverse-execution history." > > This message has changed for these two cases. Backward emulation: > > "Reached end of recorded history; stopping. > Backward execution from here not possible." > > Forward emulation: > > "Reached end of recorded history; stopping. > Following forward execution will be added to history." > > The reason for this change is that the initial message was deceiving, for > the forward case, making the user believe that forward debugging could not > continue. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31224 > --- > gdb/NEWS | 5 +++ > gdb/infrun.c | 9 +++++- > gdb/testsuite/gdb.btrace/non-stop.exp | 32 ++++++++++++------- > gdb/testsuite/gdb.reverse/break-precsave.exp | 6 ++-- > gdb/testsuite/gdb.reverse/break-reverse.exp | 4 +-- > .../gdb.reverse/machinestate-precsave.exp | 2 +- > gdb/testsuite/gdb.reverse/sigall-precsave.exp | 2 +- > 7 files changed, 41 insertions(+), 19 deletions(-) I'm not sure this change warrants a NEWS entry, but if it does, the NEWS part is approved. Thanks. Reviewed-By: Eli Zaretskii