From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61683 invoked by alias); 7 May 2015 09:05:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 61667 invoked by uid 89); 7 May 2015 09:05:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f44.google.com Received: from mail-pa0-f44.google.com (HELO mail-pa0-f44.google.com) (209.85.220.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 07 May 2015 09:05:39 +0000 Received: by pabtp1 with SMTP id tp1so34826120pab.2 for ; Thu, 07 May 2015 02:05:37 -0700 (PDT) X-Received: by 10.66.161.102 with SMTP id xr6mr5337760pab.8.1430989537211; Thu, 07 May 2015 02:05:37 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by mx.google.com with ESMTPSA id af5sm1437996pbc.90.2015.05.07.02.05.34 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 07 May 2015 02:05:35 -0700 (PDT) From: Yao Qi To: Luis Machado Cc: Pedro Alves , Yao Qi , Subject: Re: [rfc] Fix PR 18208: update /proc/pid/coredump_filter by c code References: <1429889336-12277-1-git-send-email-qiyaoltc@gmail.com> <554A3D61.8090302@redhat.com> <554A44B9.3090503@codesourcery.com> Date: Thu, 07 May 2015 09:05:00 -0000 In-Reply-To: <554A44B9.3090503@codesourcery.com> (Luis Machado's message of "Wed, 6 May 2015 13:43:37 -0300") Message-ID: <86sib8vjtv.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00135.txt.bz2 Luis Machado writes: >>> -# Get the inferior's PID. >>> -set infpid "" >>> gdb_test_multiple "info inferiors" "getting inferior pid" { >>> - -re "process \($decimal\).*\r\n$gdb_prompt $" { >>> - set infpid $expect_out(1,string) >>> + -re "process $decimal.*\r\n$gdb_prompt $" { >>> } >>> -re "Remote target.*$gdb_prompt $" { >>> # If the target does not provide PID information (like usermode QEMU= ), >> >> This "If the target does not provide PID information" check sounds >> odd now. Do we still need it? > > If we're not dealing with PID's, i don't think so. At the very start, I removed this block, but I recall that this block is used as a guard for usermode QEMU which doesn't provide PID information. With this patch applied, we'll access /proc/self/coredump_filter, but I am afraid it doesn't work as expected on usermode QEMU, because usermode QEMU just intercepts few /proc accesses and pass most of them through the host linux. Accessing /proc/QEMU_PID/coredump_filter isn't what we want in this test, so I think it's better to skip the test for usermode QEMU. Of course, I don't mind removing this block. Luis, could you try this patch and remove this block, see whether it causes fails on usermode QEMU? --=20 Yao (=E9=BD=90=E5=B0=A7)