From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83511 invoked by alias); 15 Sep 2015 11:19:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 83500 invoked by uid 89); 15 Sep 2015 11:19:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f178.google.com Received: from mail-wi0-f178.google.com (HELO mail-wi0-f178.google.com) (209.85.212.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 15 Sep 2015 11:19:30 +0000 Received: by wicgb1 with SMTP id gb1so23732066wic.1 for ; Tue, 15 Sep 2015 04:19:27 -0700 (PDT) X-Received: by 10.194.178.196 with SMTP id da4mr39875740wjc.41.1442315967764; Tue, 15 Sep 2015 04:19:27 -0700 (PDT) Received: from E107787-LIN ([195.154.84.196]) by smtp.gmail.com with ESMTPSA id v6sm20549723wjf.13.2015.09.15.04.19.26 (version=TLS1_2 cipher=AES128-SHA256 bits=128/128); Tue, 15 Sep 2015 04:19:27 -0700 (PDT) From: Yao Qi To: Pierre Langlois Cc: Yao Qi , "gdb-patches\@sourceware.org" Subject: Re: [PATCH 1/8] [AArch64] Use debug_printf instead of fprintf_unfiltered References: <1442230282-20751-1-git-send-email-pierre.langlois@arm.com> <1442230282-20751-2-git-send-email-pierre.langlois@arm.com> <86d1xk3skc.fsf@gmail.com> <55F7FBF0.5000803@arm.com> Date: Tue, 15 Sep 2015 11:19:00 -0000 In-Reply-To: <55F7FBF0.5000803@arm.com> (Pierre Langlois's message of "Tue, 15 Sep 2015 12:07:28 +0100") Message-ID: <86si6g2amf.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00316.txt.bz2 Pierre Langlois writes: > Should the other if statements like this one have braces? I can fix those > too in this patch. > > @@ -261,10 +261,8 @@ decode_add_sub_imm (CORE_ADDR addr, uint32_t insn, u= nsigned *rd, unsigned *rn, > *imm =3D -*imm; > > if (aarch64_debug) > - fprintf_unfiltered (gdb_stdlog, > - "decode: 0x%s 0x%x add x%u, x%u, #%d\n", > - core_addr_to_string_nz (addr), insn, *rd, *rn, > - *imm); > + debug_printf ("decode: 0x%s 0x%x add x%u, x%u, #%d\n", > + core_addr_to_string_nz (addr), insn, *rd, *rn, *imm= ); > return 1; > } > return 0; If you want to fix them, yes, please. --=20 Yao (=E9=BD=90=E5=B0=A7)