From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65773 invoked by alias); 26 Nov 2015 15:53:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 64547 invoked by uid 89); 26 Nov 2015 15:53:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f42.google.com Received: from mail-pa0-f42.google.com (HELO mail-pa0-f42.google.com) (209.85.220.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 26 Nov 2015 15:53:01 +0000 Received: by pacdm15 with SMTP id dm15so89647938pac.3 for ; Thu, 26 Nov 2015 07:52:59 -0800 (PST) X-Received: by 10.98.2.70 with SMTP id 67mr40604851pfc.133.1448553179395; Thu, 26 Nov 2015 07:52:59 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id 24sm28342527pfr.27.2015.11.26.07.52.56 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 26 Nov 2015 07:52:58 -0800 (PST) From: Yao Qi To: Pedro Alves Cc: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 02/18] Remote all-stop-on-top-of-non-stop References: <1444836486-25679-1-git-send-email-palves@redhat.com> <1444836486-25679-3-git-send-email-palves@redhat.com> <86vb9x1u2h.fsf@gmail.com> <56533372.3030805@redhat.com> <56535D4C.9030203@redhat.com> Date: Thu, 26 Nov 2015 15:53:00 -0000 In-Reply-To: <56535D4C.9030203@redhat.com> (Pedro Alves's message of "Mon, 23 Nov 2015 18:39:08 +0000") Message-ID: <86si3swyei.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00565.txt.bz2 Pedro Alves writes: > diff --git i/gdb/remote.c w/gdb/remote.c > index 1618ea1..624f60d 100644 > --- i/gdb/remote.c > +++ w/gdb/remote.c > @@ -13036,12 +13036,20 @@ remote_async (struct target_ops *ops, int enabl= e) > event loop to process them. */ > if (!QUEUE_is_empty (stop_reply_p, stop_reply_queue)) > mark_async_event_handler (remote_async_inferior_event_token); > + /* For simplicity, below we clear the pending events token > + without remembering whether it is marked, so here we always > + mark it. If there's actually no pending notification to > + process, this ends up being a no-op (other than a spurious > + event-loop wakeup). */ > if (target_is_non_stop_p ()) > mark_async_event_handler (rs->notif_state->get_pending_events_tok= en); > } > else > { > serial_async (rs->remote_desc, NULL, NULL); > + /* If the core is disabling async, it doesn't want to be > + disturbed with target events. Clear all async event sources > + too. */ > clear_async_event_handler (remote_async_inferior_event_token); > if (target_is_non_stop_p ()) > clear_async_event_handler (rs->notif_state->get_pending_events_to= ken); These comments are good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)