From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124771 invoked by alias); 11 May 2016 12:09:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124756 invoked by uid 89); 11 May 2016 12:09:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1691, HX-Received:10.66.134.15 X-HELO: mail-pa0-f68.google.com Received: from mail-pa0-f68.google.com (HELO mail-pa0-f68.google.com) (209.85.220.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 11 May 2016 12:09:38 +0000 Received: by mail-pa0-f68.google.com with SMTP id gh9so3486953pac.0 for ; Wed, 11 May 2016 05:09:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Ii2/yPlqXUK7qJjykcZKjUBpsV9aIiOTVUSvgfl3kNA=; b=fX/R1mTXOvKpr6XJz6TD0SCQz0QK2BO5TXk3wG9z0KJyEhOE1+n5DBPSORzOapbEi4 4jgjnGZAaVztgtkbbK7q8XK6JuBCHRYAN7vaR0ZZkocRP5On9Uuod+3+GEA6O+CjdPad e+l3w9MacGwXcQNqqDdAVAJO4X0zuOvc5TprZXHD+nljoBAbx3rWoyNct4X18Ejkrqsq HAULxMCZ/O1CulAUZvF01TT8hYwzafCq4vv6yOsGJb7fsyRcnJBSU1oJF2jabZ2ZgBFX mDEGQJC7Z0TN5u168x5Y9lMkFZmb52q38oKLCc2mSc+T6peDhtIDD8+xv4hf+Y69+9qK mBHg== X-Gm-Message-State: AOPr4FXjE2yR6s3hkBL02TwSpI0J1TEPV27fFKx8r92qdp9egPv27xTSrF3bIAQ8s3bu9g== X-Received: by 10.66.134.15 with SMTP id pg15mr4303354pab.98.1462968576836; Wed, 11 May 2016 05:09:36 -0700 (PDT) Received: from E107787-LIN (gcc113.osuosl.org. [140.211.9.71]) by smtp.gmail.com with ESMTPSA id t8sm11829434paw.16.2016.05.11.05.09.34 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 11 May 2016 05:09:36 -0700 (PDT) From: Yao Qi To: Bernhard Heckel Cc: qiyaoltc@gmail.com, gdb-patches@sourceware.org Subject: Re: [PATCH 2/4] Fortran, typeprint: Take level of details into account when printing elements of a structure. References: <1462889739-30359-1-git-send-email-bernhard.heckel@intel.com> <1462889739-30359-3-git-send-email-bernhard.heckel@intel.com> Date: Wed, 11 May 2016 12:09:00 -0000 In-Reply-To: <1462889739-30359-3-git-send-email-bernhard.heckel@intel.com> (Bernhard Heckel's message of "Tue, 10 May 2016 16:15:37 +0200") Message-ID: <86shxodceb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00181.txt.bz2 Bernhard Heckel writes: Hi Bernhard, Patch is good to me, some comments below, > According to the typeprint's description, elements of a structure > should not be printed when show is <=3D -1. s/<=3D -1/< 0/ ? > This variable is also used to distinguish the level of details > between "ptype" and "whatis" expressions. > > Before: > (gdb) whatis t1v > type =3D Type t1 > integer(kind=3D4) :: t1_i > real(kind=3D4) :: t1_r > End Type t1 > > After: > (gdb) whatis t1v > type =3D Type t1 > > 2016-05-09 Bernhard Heckel > > gdb/Changelog: > * f-typeprint.c (f_type_print_base): Don't print structure fields when s= how is <=3D -1. > This line is too long. s/ <=3D -1/ < 0/ > diff --git a/gdb/testsuite/gdb.fortran/whatis_type.exp b/gdb/testsuite/gd= b.fortran/whatis_type.exp > index edaf4fd..2caebe6 100644 > --- a/gdb/testsuite/gdb.fortran/whatis_type.exp > +++ b/gdb/testsuite/gdb.fortran/whatis_type.exp > @@ -38,17 +38,8 @@ gdb_continue_to_breakpoint "bp1" > set t1_i "$int :: t1_i" > set t1_r "$real :: t1_r" >=20=20 > -gdb_test "whatis t1" \ > - [multi_line "type =3D Type t1" \ > - " $t1_i" \ > - " $t1_r" \ > - "End Type t1"] > - > -gdb_test "whatis t1v" \ > - [multi_line "type =3D Type t1" \ > - " $t1_i" \ > - " $t1_r" \ > - "End Type t1"] > +gdb_test "whatis t1" "type =3D Type t1" > +gdb_test "whatis t1v" "type =3D Type t1" >=20=20 > gdb_test "ptype t1" \ > [multi_line "type =3D Type t1" \ This patch can be the first one in this series, and you don't have to adjust the test of "whatis" back and forth (I mean in patch 1 and 2). --=20 Yao (=E9=BD=90=E5=B0=A7)