From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GE7+BG14BWb3jRkAWB0awg (envelope-from ) for ; Thu, 28 Mar 2024 10:02:21 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=QFie0MTD; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0F7611E0C0; Thu, 28 Mar 2024 10:02:21 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id ECAAA1E030 for ; Thu, 28 Mar 2024 10:02:18 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 94BA53858403 for ; Thu, 28 Mar 2024 14:02:18 +0000 (GMT) Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id E16AF3858D1E for ; Thu, 28 Mar 2024 14:01:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E16AF3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E16AF3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711634521; cv=none; b=h2DpCxKdFPs+KjR9YEZLzq+R1O3X6hMjS3swU6p8Ct2vUbtCVjP44m3ugNGec5wNDQxOGl4+lmGORT4UvXQ6CMY2PLE3aMBaixnq6AtsNVkwhg6Blk9/buYXCeywKlbBb5PpIsK3ydxB+9jxnU7XNu17ZhKXubUsfZnhiuE2rmI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711634521; c=relaxed/simple; bh=walrSlpVYo+S+Q5ybKAdPangdMG8YxDD/nnDkTknfl8=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=NHvHqoS4R7+VyErFrslMY/2HRRSNdDfUKl4DO4dBSxDnkLkE+GLPQ9hfZ/m/nrcJzgg4QPw53R0U/Lz5sqgryAhPqjSdGkvM83rAMNj8Mj4gtaKPak7B26uXAnXqQRLpgFxkZFQSu3uB5WNbL87SYXtFNshC87F8tXXI8g64oNQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rpqKN-00038l-0L; Thu, 28 Mar 2024 10:01:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=gdoJByxrT67JB3W/qsKVH9nD8rALP3B9LOO1NVf2MJA=; b=QFie0MTDD5KV C2MWv635KG3fvJlvz4ePpQp8adU1fx+PFyBdvz/RuVQFNNoxjdWtKriX+Yr527f9S7FOFsaqzH34R VUsLLRNadVv7nWGmAkHQeVMCYzpmjcQbO4zSq6+vxKx/8IByBi6Uz6goUDgxFxqPs+htdjWvEdBVf ostC/u+BSvthRLxnzz5YRb/payslSbOc/6SWcRW/Hxqbj+8XlgDDuOwaz3+7gHylw5S6G4NM4nHQ5 7zONzU2ZFA61xPKhh6E1QDDsZaxm748YnwaeFuXhRVyNLS9qPAHNlShjVlET5LTvB93c25X9OMkQd Mdnf1S7c5sC0ACWAu9xUng==; Date: Thu, 28 Mar 2024 16:01:56 +0200 Message-Id: <86sf0afoa3.fsf@gnu.org> From: Eli Zaretskii To: Abdul Basit Ijaz Cc: gdb-patches@sourceware.org, JiniSusan.George@amd.com, tom@tromey.com In-Reply-To: <20240328120528.30382-8-abdul.b.ijaz@intel.com> (message from Abdul Basit Ijaz on Thu, 28 Mar 2024 13:05:25 +0100) Subject: Re: [PATCH v6 07/10] gdb: Skip trampoline functions for the return command. References: <20240328120528.30382-1-abdul.b.ijaz@intel.com> <20240328120528.30382-8-abdul.b.ijaz@intel.com> X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org > From: Abdul Basit Ijaz > Cc: abdul.b.ijaz@intel.com, > JiniSusan.George@amd.com, > tom@tromey.com, > eliz@gnu.org > Date: Thu, 28 Mar 2024 13:05:25 +0100 > > gdb/doc/gdb.texinfo | 6 +++--- > gdb/stack.c | 11 +++++++++++ > gdb/testsuite/gdb.fortran/func-trampoline.exp | 10 +++++++++- > 3 files changed, 23 insertions(+), 4 deletions(-) > > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 222faba5da3..a6f74373dfe 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -6475,9 +6475,9 @@ DWARF trampolines marked via DW_AT_trampoline are supported by this. > When issuing a @code{backtrace}, if @code{skip-trampoline-functions} is set, > @value{GDBN} will skip trampoline frames while printing the stack. > > -When issuing a @code{finish}, @code{reverse-finish} or @code{up}, if > -@code{skip-trampoline-functions} is set, @value{GDBN} will skip trampoline > -frames while returning from the target function. > +When issuing a @code{finish}, @code{reverse-finish}, @code{up} or > +@code{return}, if @code{skip-trampoline-functions} is set, @value{GDBN} will > +skip trampoline frames while returning from the target function. > > Currently, only DWARF trampolines marked via DW_AT_trampoline are supported by > this. The gdb.texinfo part is okay, thanks. Reviewed-By: Eli Zaretskii