From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6895 invoked by alias); 29 Mar 2016 12:01:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6884 invoked by uid 89); 29 Mar 2016 12:01:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:690 X-HELO: mail-pf0-f169.google.com Received: from mail-pf0-f169.google.com (HELO mail-pf0-f169.google.com) (209.85.192.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 29 Mar 2016 12:01:33 +0000 Received: by mail-pf0-f169.google.com with SMTP id u190so12702047pfb.3 for ; Tue, 29 Mar 2016 05:01:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=E2me788XILLMp8vfofyCjY96mg28NLN3qErsQUh8DFU=; b=nFLwqcLpDXFYpPrt7FzorprSIfw8IZdPjoGYrJhpqhTpkHkeqKughMeReoddtSpo5c t5OpDtjXhzDHmO/mu31CdXk1gMkYEL/5WqmLXGZqNOwpGuNWfMXg2ojy/Fq8VhvK/zhA LvDzJhA4Y92CuQHzUbXCccoN69wlK9WIj3dWM7+VhyJdOq5OzOKNeqf5sM6CocoWRl2W AFMZ7cv1IA8zpzkiin7+I0WHe01drNrjnkW140hHubrd9Z+pPwwfkVZKvCaeZaLyzr2h HN7zFyGHMpvG/ZqnviXVDr8K3FN7ez/vWVu+kqCGCIkMS5RrEgote7gxjavADA2lkoV2 FyAw== X-Gm-Message-State: AD7BkJKFSszIe7a1iGri3gaNZ9jWDKz81n5aPJmS2tjGcd0a6Te4EL22WR2CTYFXuLLb9g== X-Received: by 10.98.68.71 with SMTP id r68mr2766528pfa.119.1459252891347; Tue, 29 Mar 2016 05:01:31 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id v3sm42876936par.17.2016.03.29.05.01.28 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 29 Mar 2016 05:01:29 -0700 (PDT) From: Yao Qi To: Don Breazeal Cc: "Gustavo\, Luis" , "gdb-patches\@sourceware.org" Subject: Re: [PATCH] Eliminate -var-create error for optzd ptr to struct References: <1456273154-28629-1-git-send-email-donb@codesourcery.com> <56CD03F5.6080505@codesourcery.com> <56CDDAEE.1030504@codesourcery.com> Date: Tue, 29 Mar 2016 12:01:00 -0000 In-Reply-To: <56CDDAEE.1030504@codesourcery.com> (Don Breazeal's message of "Wed, 24 Feb 2016 08:31:42 -0800") Message-ID: <86r3etsdbh.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00511.txt.bz2 Don Breazeal writes: >>> @@ -1203,9 +1203,10 @@ value_actual_type (struct value *value, int reso= lve_simple_types, >>> /* If result's target type is TYPE_CODE_STRUCT, proceed to >>> fetch its rtti type. */ >>> if ((TYPE_CODE (result) =3D=3D TYPE_CODE_PTR >>> - || TYPE_CODE (result) =3D=3D TYPE_CODE_REF) >>> + || TYPE_CODE (result) =3D=3D TYPE_CODE_REF) >>=20 >> Is this just a formatting change? > > Yes. I should have documented that in the ChangeLog. If it is just a format change, you can move it to a separate patch, and commit it as obvious. Don't mix format change with your bug fix patch. --=20 Yao (=E9=BD=90=E5=B0=A7)