From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115436 invoked by alias); 6 Jun 2016 13:23:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115427 invoked by uid 89); 6 Jun 2016 13:23:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:545 X-HELO: mail-pf0-f177.google.com Received: from mail-pf0-f177.google.com (HELO mail-pf0-f177.google.com) (209.85.192.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 06 Jun 2016 13:23:16 +0000 Received: by mail-pf0-f177.google.com with SMTP id g64so67083254pfb.2 for ; Mon, 06 Jun 2016 06:23:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=t8KiLXujr8gvtkVqE6inWJFh5Q2wDIFl9SEMySmrRto=; b=QFQUF99M8/r0mQlsYzNa2hYxUeQuGl8idAKJKOfL6QwLvZBZDpAjgQv/JgNiWMUjbE YB5CZBgLaabGVZ84npV4/uMsYMJmwOJ4N8xMJtzcZzw1Wx+ooDwAMRpDZpGUR0oxp2Lw OtmgwznLqjeUHEYhR5UfNEwbkeXHGWOq5D7zn6HC/4UYIgniE8q2aH25HqSavkfyDmrn YrrD4dKUa9r7vLphDSW/hZY/D0wWXB99bczb8nGmQrFN7tINYmNY7tk3WoE/5TOBFxX8 mg4hwozD+vXde0ujrsGhloAA5auYGbvoyiYBDk7Kx9JIWNK/Pl6GbcE18Pn7CtMFUcoV vV/w== X-Gm-Message-State: ALyK8tIG63npwQafUzwGRDLwmAbrHcFFh9PNKqlHCm8mpAjRd/SBENSo74fn9Rv2qmmTQg== X-Received: by 10.98.44.78 with SMTP id s75mr25515857pfs.17.1465219395137; Mon, 06 Jun 2016 06:23:15 -0700 (PDT) Received: from E107787-LIN (gcc113.osuosl.org. [140.211.9.71]) by smtp.gmail.com with ESMTPSA id fl1sm25410793pab.43.2016.06.06.06.23.13 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 06 Jun 2016 06:23:14 -0700 (PDT) From: Yao Qi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 2/3] Move filename extensions into language_defn References: <1465051760-25840-1-git-send-email-tom@tromey.com> <1465051760-25840-3-git-send-email-tom@tromey.com> Date: Mon, 06 Jun 2016 13:23:00 -0000 In-Reply-To: <1465051760-25840-3-git-send-email-tom@tromey.com> (Tom Tromey's message of "Sat, 4 Jun 2016 08:49:19 -0600") Message-ID: <86r3cawix0.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00083.txt.bz2 Tom Tromey writes: > This moves filename extensions from a function in symfile.c out to > each language_defn. I think this is an improvement because it means > less digging around when writing a new language port. Patch is good to me. Note that we can improve it further by moving language related stuff out of symfile.c to language.c. Then, we can remove filename_language_table in symfile.c, and use array languages in language.c as a replacement. --=20 Yao (=E9=BD=90=E5=B0=A7)