From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73684 invoked by alias); 16 May 2017 09:14:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 73090 invoked by uid 89); 16 May 2017 09:14:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=transfer, Transfer, Mirror X-HELO: mail-pg0-f42.google.com Received: from mail-pg0-f42.google.com (HELO mail-pg0-f42.google.com) (74.125.83.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 May 2017 09:14:56 +0000 Received: by mail-pg0-f42.google.com with SMTP id x64so54063097pgd.3 for ; Tue, 16 May 2017 02:14:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=yM16i1xzr9Vfsn6RX+XdzUrh8xZQyEs9xJVlLVRlkC8=; b=sVNeel6f6f7KUpwoFOMacZeBilER5E3OBoDPuV4bnICnJX/A8Aw+tGZF1w7ANXHZiZ h8eQ7VVqOg1q2ow9NWN4imZCbMrtLub2mtBvb4aYrr0ebW/AU49KE3UPLAfB9Vz23Geu dn7nRuzdpB+Coj7qKb8rtoYQ2gcCNx/IgmprXmAzrL+kcDDYM/QSpwb2BGB6TJgYhYd4 M3DJDtRtMQ3+j0X/4w+rHIiS2VC8Bjjif8++/FrKO0oestaLp7j2Om8iQmw4eMajLEaG apN9piqgmVqaJMGCiMuBXocIQtVWC7mXmZguA+Tlnn7pTYcaEn5mrVNYaft3+l4ur5Rs Bjrg== X-Gm-Message-State: AODbwcBfiPkHB6bdaevoEE39ZCxCmKDK6TY+lpKKgywlSmDrlcBFirf0 W7Q8VLkbAcWneymy X-Received: by 10.84.193.3 with SMTP id e3mr14751789pld.21.1494926097384; Tue, 16 May 2017 02:14:57 -0700 (PDT) Received: from E107787-LIN (gcc114.osuosl.org. [140.211.9.72]) by smtp.gmail.com with ESMTPSA id g20sm24757471pfk.21.2017.05.16.02.14.55 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 16 May 2017 02:14:56 -0700 (PDT) From: Yao Qi To: Andreas Arnez Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 10/19] write_pieced_value: Transfer least significant bits into bit-field References: <1494352015-10465-1-git-send-email-arnez@linux.vnet.ibm.com> <1494352015-10465-11-git-send-email-arnez@linux.vnet.ibm.com> Date: Tue, 16 May 2017 09:14:00 -0000 In-Reply-To: <1494352015-10465-11-git-send-email-arnez@linux.vnet.ibm.com> (Andreas Arnez's message of "Tue, 9 May 2017 19:46:06 +0200") Message-ID: <86r2zp9n8x.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00329.txt.bz2 Andreas Arnez writes: > gdb/ChangeLog: > > * dwarf2loc.c (write_pieced_value): When writing to a bit-field, > transfer the source value's least significant bits, instead of its > lowest-addressed ones. Rename type_len to max_offset. > (read_pieced_value): Mirror above changes to write_pieced_value as > applicable. LGTM. --=20 Yao (=E9=BD=90=E5=B0=A7)