From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8pEYHKWrhmaGOBsAWB0awg (envelope-from ) for ; Thu, 04 Jul 2024 10:03:17 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=gIRtaC8K; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 609021E0C3; Thu, 4 Jul 2024 10:03:17 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CBA451E030 for ; Thu, 4 Jul 2024 10:03:12 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 71595384A45F for ; Thu, 4 Jul 2024 14:03:12 +0000 (GMT) Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 7C63D3858C41 for ; Thu, 4 Jul 2024 14:02:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7C63D3858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7C63D3858C41 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1720101774; cv=none; b=PicrztJHf6eIMr4bMSvj3jUzN/K+G12JPYc5lCq/5VA6vTtlJLGRnLWjpKqroUljDx0nBXvjKQ1mZi962wrVdErvIXoZBSC3kVK6obBFLxLF0y1Ge5ErseuIhE54bYMtuAlvAbxn6QmdRN3jrWcHxuvFxVo9T5oT4gG2tDLpTZU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1720101774; c=relaxed/simple; bh=PpAbGf7NGWS2Yuwm7lrOSYRQGMgcfRrZGqhvr6s1T5U=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=RnDjEGReRIQsWQl42a5fP0rhcVX30aErtgSR1RAUXckB8OUkOXlSPpZ0iWhxH0BK81iSm2kEFVQQB8BEAblGtu8GKXHvKFn5SfV0sqGH7BwL8i5KJTev7UmEE2sU+wULmLf7zMiW1L0b8U47kf6wChXC9GNJmbYc28PetQwdIgA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPN2x-0003yj-6S; Thu, 04 Jul 2024 10:02:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=vKrvLL1AyXwVQya4wPh90HYe0yMu/SJi3IVVqovjIc4=; b=gIRtaC8KGmpX ay6TuY+v+iphM2GI+VzyCIRebAJIzRPnAuSe/fDFE4JT7t0NYpasee2IrU3DWINITlO2zfGWnKH7/ W8A6KwPhY6Y5jXxRagDstqYGblwH4q79AB1QEJZgBlNNol8Fsyq2EsdTWPp4mBwB8iwK2U1y945WO D+DHKIFAqMU7seMJD/7OxTccF+QBQv31o/hKV6+BAyJcpa5I541OlZ0BoT1y2gEyAs1iaHn8nA58S 1ko9Xt4/KvYBBryWMD0br/FCHFxfK+jzoArCc9hgpm3+ga5IzvRTPcUXWZ2F2c5WxOTHWhVxFv1Vc jXRmuywucSqfx15roHOmfg==; Date: Thu, 04 Jul 2024 17:02:27 +0300 Message-Id: <86r0c98dcc.fsf@gnu.org> From: Eli Zaretskii To: "Schimpe, Christina" Cc: gdb-patches@sourceware.org, felix.willgerodt@intel.com, luis.machado@arm.com In-Reply-To: (christina.schimpe@intel.com) Subject: Re: [PATCH v4 2/2] LAM: Enable tagged pointer support for watchpoints. References: <20240704101736.3074236-1-christina.schimpe@intel.com> <20240704101736.3074236-3-christina.schimpe@intel.com> <86tth58gk7.fsf@gnu.org> X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > From: "Schimpe, Christina" > CC: "gdb-patches@sourceware.org" , "Willgerodt, > Felix" , "luis.machado@arm.com" > > Date: Thu, 4 Jul 2024 13:05:35 +0000 > > > > diff --git a/gdb/NEWS b/gdb/NEWS > > > index 47677cb773a..fcbb89e8bf8 100644 > > > --- a/gdb/NEWS > > > +++ b/gdb/NEWS > > > @@ -3,6 +3,8 @@ > > > > > > *** Changes since GDB 15 > > > > > > +* GDB now supports watchpoints for tagged data pointers on amd64. > > > + > > > * Debugger Adapter Protocol changes > > > > Thanks. The above NEWS text is okay, but I wonder whether we explain > > anywhere what are "tagged data pointers". > > > > Reviewed-By: Eli Zaretskii > > Thanks for the review. I understand this can be a bit confusing. > Is " GDB now supports watchpoints for tagged pointers used for data accesses on amd64." better? > Or, we could also just write: " GDB now supports watchpoints for tagged pointers on amd64.", as watchpoints are usually just data breakpoints. > > What do you think? My bother is actually about what we say in the manual, not in NEWS. If the manual explains this terminology, it is fine to leave it unexplained in NEWS, as users are expected to turn to the manual for the details of the NEWS entries they are interested in. But if this is not explained in the manual, then we should either explain it, or do that in NEWS entry itself, and in the latter case I'm afraid your suggestion above is not enough because "tagged pointers" are not explained anywhere, either.