From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 521 invoked by alias); 11 Jun 2003 18:56:47 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 409 invoked from network); 11 Jun 2003 18:56:45 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (62.163.169.212) by sources.redhat.com with SMTP; 11 Jun 2003 18:56:45 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p2/8.12.5) with ESMTP id h5BIubN1000246; Wed, 11 Jun 2003 20:56:37 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p2/8.12.6) with ESMTP id h5BIuaVh000367; Wed, 11 Jun 2003 20:56:36 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p2/8.12.6/Submit) id h5BIuaCl000364; Wed, 11 Jun 2003 20:56:36 +0200 (CEST) To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [patch rfc] -Wmissing-prototypes round #3 References: <3EE76A05.2050409@redhat.com> From: Mark Kettenis Date: Wed, 11 Jun 2003 18:56:00 -0000 In-Reply-To: Andrew Cagney's message of "Wed, 11 Jun 2003 13:42:29 -0400" Message-ID: <86ptlk8mu3.fsf@elgar.kettenis.dyndns.org> X-SW-Source: 2003-06/txt/msg00375.txt.bz2 Andrew Cagney writes: > - move function declarations to CPU-tdep.h, from config/CPU/tm-CPU.h > Ex, m68k's delta68 functions previously in tm-delta.h. > This ensures that the function declaration is always visible, and that a > global function in CPU-tdep.c has its declaration in the corresponding > CPU-tdep.h file. The config/CPU/tm-CPU.h files were also updated to > include the corresponding "CPU-tdep.h". I'm not sure whether this part of your patch is a good idea. Quite a number of function declarations in config/CPU/tm-CPU.h are for things that haven't been multi-arched yet. Keeping the function declaration next to the #define that uses them, makes it easier to remove them once they're no longer needed. Mark