From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18955 invoked by alias); 23 Apr 2015 14:28:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18911 invoked by uid 89); 23 Apr 2015 14:28:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f44.google.com Received: from mail-pa0-f44.google.com (HELO mail-pa0-f44.google.com) (209.85.220.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 23 Apr 2015 14:28:16 +0000 Received: by paboj16 with SMTP id oj16so19646919pab.0 for ; Thu, 23 Apr 2015 07:28:14 -0700 (PDT) X-Received: by 10.70.24.130 with SMTP id u2mr5796559pdf.147.1429799294243; Thu, 23 Apr 2015 07:28:14 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by mx.google.com with ESMTPSA id y13sm8402436pas.37.2015.04.23.07.28.12 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 23 Apr 2015 07:28:13 -0700 (PDT) From: Yao Qi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 03/24] Fix gdb.base/interrupt.exp racy fail against gdbserver References: <1429639711-16459-1-git-send-email-palves@redhat.com> <1429639711-16459-4-git-send-email-palves@redhat.com> Date: Thu, 23 Apr 2015 14:28:00 -0000 In-Reply-To: <1429639711-16459-4-git-send-email-palves@redhat.com> (Pedro Alves's message of "Tue, 21 Apr 2015 19:08:10 +0100") Message-ID: <86pp6uyl52.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00884.txt.bz2 Pedro Alves writes: > Fix this by removing $inferior_spawn_id from the set of spawn ids > expect is watching as soon as we see the "end of file" string out of > the inferior spawn id, using an indirect spawn id list. > Yeah, it is clever to use indirect spawn ids here... > Tested on x86-64 Fedora 20, native and gdbserver (both target remote > and extended-remote). > > gdb/testsuite/ChangeLog: > 2015-04-21 Pedro Alves > > * gdb.base/interrupt.exp: Rename saw_eof to saw_end_of_file. Use The first sentence can be removed, it is in 02/24. > an indirect spawn id list holding $inferior_spawn_id instead of > $inferior_spawn_id directly. On "of of file", remove On "end of file". > $inferior_spawn_id from the indirect list. Patch is good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)