From: Yao Qi <qiyaoltc@gmail.com>
To: Mark Wielaard <mjw@redhat.com>
Cc: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/6] Use PTRACE_GETREGSET and PTRACE_SETREGSET in arm-linux-nat.c
Date: Tue, 02 Jun 2015 09:30:00 -0000 [thread overview]
Message-ID: <86pp5eo3ta.fsf@gmail.com> (raw)
In-Reply-To: <1433231848.4538.212.camel@bordewijk.wildebeest.org> (Mark Wielaard's message of "Tue, 02 Jun 2015 09:57:28 +0200")
Mark Wielaard <mjw@redhat.com> writes:
> I believe this caused a build regression on i386. After this patch
> series went in various buildbot i386 buildslaves builds started failing:
> http://gdb-build.sergiodj.net/waterfall
>
> ../../binutils-gdb/gdb/i386-linux-nat.c: In function ‘fetch_xstateregs’:
> ../../binutils-gdb/gdb/i386-linux-nat.c:329:8: error:
> ‘have_ptrace_getregset’ undeclared (first use in this function)
> ../../binutils-gdb/gdb/i386-linux-nat.c:329:8: note: each undeclared
> identifier is reported only once for each function it appears in
> ../../binutils-gdb/gdb/i386-linux-nat.c: In function ‘store_xstateregs’:
> ../../binutils-gdb/gdb/i386-linux-nat.c:352:8: error:
> ‘have_ptrace_getregset’ undeclared (first use in this function)
> make[2]: *** [i386-linux-nat.o] Error 1
>
> Could you take a look?
Oh, I forget rebuilding GDB for i686 target. This patch fixes the build failure.
--
Yao (齐尧)
From: Yao Qi <yao.qi@linaro.org>
Date: Tue, 2 Jun 2015 10:28:03 +0100
Subject: [PATCH] Include linux-nat.h in i386-linux-nat.c
This commit fixes a build failure on i386-linux.
gdb:
2015-06-02 Yao Qi <yao.qi@linaro.org>
* i386-linux-nat.c: Include linux-nat.h.
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 5867465..eca000f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2015-06-02 Yao Qi <yao.qi@linaro.org>
+
+ * i386-linux-nat.c: Include linux-nat.h.
+
2015-06-01 Andreas Schwab <schwab@linux-m68k.org>
Jan Kratochvil <jan.kratochvil@redhat.com>
diff --git a/gdb/i386-linux-nat.c b/gdb/i386-linux-nat.c
index 5666361..4401a2f 100644
--- a/gdb/i386-linux-nat.c
+++ b/gdb/i386-linux-nat.c
@@ -33,6 +33,7 @@
#include "i386-linux-tdep.h"
#include "x86-xstate.h"
+#include "linux-nat.h"
#include "x86-linux-nat.h"
#include "nat/linux-ptrace.h"
prev parent reply other threads:[~2015-06-02 9:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 14:20 Yao Qi
2015-05-28 14:20 ` [PATCH 5/6] Fetch and store FP registers by PTRACE_{G,S}ETREGSET Yao Qi
2015-05-28 14:20 ` [PATCH 6/6] Fetch and store VFP " Yao Qi
2015-05-28 14:20 ` [PATCH 4/6] Fetch and store GP " Yao Qi
2015-05-28 18:50 ` Doug Evans
2015-05-29 13:11 ` Yao Qi
2015-05-28 14:20 ` [PATCH 2/6] Move have_ptrace_getregset to linux-nat.c Yao Qi
2015-05-28 14:20 ` [PATCH 1/6] Move PTRACE_GETREGSET and PTRACE_SETREGSET to nat/linux-ptrace.h Yao Qi
2015-05-28 14:20 ` [PATCH 3/6] Check whether kernel supports PTRACE_GETREGSET Yao Qi
2015-05-29 8:10 ` [PATCH 0/6] Use PTRACE_GETREGSET and PTRACE_SETREGSET in arm-linux-nat.c Gary Benson
2015-06-01 11:17 ` Yao Qi
2015-06-02 7:57 ` Mark Wielaard
2015-06-02 9:30 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86pp5eo3ta.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=mjw@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox