From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62188 invoked by alias); 15 Sep 2015 07:22:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62173 invoked by uid 89); 15 Sep 2015 07:22:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f176.google.com Received: from mail-wi0-f176.google.com (HELO mail-wi0-f176.google.com) (209.85.212.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 15 Sep 2015 07:22:13 +0000 Received: by wicfx3 with SMTP id fx3so13937889wic.0 for ; Tue, 15 Sep 2015 00:22:10 -0700 (PDT) X-Received: by 10.194.179.103 with SMTP id df7mr7019879wjc.69.1442301730441; Tue, 15 Sep 2015 00:22:10 -0700 (PDT) Received: from E107787-LIN ([195.154.84.196]) by smtp.gmail.com with ESMTPSA id uo6sm19443581wjc.1.2015.09.15.00.22.09 (version=TLS1_2 cipher=AES128-SHA256 bits=128/128); Tue, 15 Sep 2015 00:22:09 -0700 (PDT) From: Yao Qi To: Antoine Tremblay Cc: Yao Qi , Subject: Re: [PATCH 5/7] Add support for software single step on ARM aarch32-linux in GDBServer. References: <1441973603-15247-1-git-send-email-antoine.tremblay@ericsson.com> <1441973603-15247-6-git-send-email-antoine.tremblay@ericsson.com> <8637yh5kpz.fsf@gmail.com> <55F6C071.1040104@ericsson.com> <86twqx3rty.fsf@gmail.com> <55F703AF.5010707@ericsson.com> Date: Tue, 15 Sep 2015 07:22:00 -0000 In-Reply-To: <55F703AF.5010707@ericsson.com> (Antoine Tremblay's message of "Mon, 14 Sep 2015 13:28:15 -0400") Message-ID: <86pp1k406c.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00304.txt.bz2 Antoine Tremblay writes: > Well my goal is to have feature parity between GDB and GDBServer as > much as possible, so yes I would like to support BE8 in GDBServer. This feature parity should be addressed separately, not by this patch series. > > Since BE8 support entails endianness awareness I can't split them out > logically based on the BE8 feature, that would be writing the > breakpoint handling code code without endianness support and then > rewriting it completely with a patch labeled BE8 that would teach > endianness to these features. This would be a major overhead with no > value imho. No, the value is we can make progress and address one specific problem in one time. Patches are easy to review and discuss in this way. I don't think BE8 GDBserver is fully supported, and I don't know anyone running GDBserver on BE8. > > Maybe I misunderstood what you meant ? > > I think it's better to include endianness awareness in GDBServer from > patch1 and not redo the work. In that case BE8 support becomes only 1 > variable in a function and thus does not need it's own patch. =46rom reviewer's point of view, I'd like each patch series is self-contained and independent. Your patch series is about supporting software breakpoint, software single step and tracepoint in ARM linux GDBserver. Why do we need to worry about the different endianness of GDBserver and inferior in your patch series? Your code may be right, and we may need them sooner or later, but we can't do all of them in one go. --=20 Yao (=E9=BD=90=E5=B0=A7)