From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6211 invoked by alias); 16 Oct 2015 12:24:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5890 invoked by uid 89); 16 Oct 2015 12:24:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f48.google.com Received: from mail-pa0-f48.google.com (HELO mail-pa0-f48.google.com) (209.85.220.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 16 Oct 2015 12:24:08 +0000 Received: by padcn9 with SMTP id cn9so4938702pad.2 for ; Fri, 16 Oct 2015 05:24:06 -0700 (PDT) X-Received: by 10.66.162.168 with SMTP id yb8mr16273880pab.48.1444996347671; Fri, 16 Oct 2015 04:52:27 -0700 (PDT) Received: from E107787-LIN (gcc2-power8.osuosl.org. [140.211.9.43]) by smtp.gmail.com with ESMTPSA id fx4sm20857026pbb.92.2015.10.16.04.52.25 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 16 Oct 2015 04:52:27 -0700 (PDT) From: Yao Qi To: Antoine Tremblay Cc: Subject: Re: [PATCH v2 7/7] Support software breakpoints for ARM linux in GDBServer. References: <1444063455-31558-1-git-send-email-antoine.tremblay@ericsson.com> <1444063455-31558-8-git-send-email-antoine.tremblay@ericsson.com> Date: Fri, 16 Oct 2015 12:24:00 -0000 In-Reply-To: <1444063455-31558-8-git-send-email-antoine.tremblay@ericsson.com> (Antoine Tremblay's message of "Mon, 5 Oct 2015 12:44:15 -0400") Message-ID: <86pp0f2fpk.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00281.txt.bz2 Antoine Tremblay writes: > +/* Get the breakpoint from the remote kind > + 2 is thumb-16 > + 3 is thumb2-32 > + 4 is arm > +*/ Need comment /* Implementation of .... */ > +static const unsigned char * > +arm_breakpoint_from_kind (int *kind) > +{ > + switch (*kind) { Wrong format. "{" should be put in the next line. > + case 2: > + return (unsigned char *) &thumb_breakpoint; > + case 3: > + *kind =3D 4; > + return (unsigned char *) &thumb2_breakpoint; > + case 4: > + return (unsigned char *) &arm_breakpoint; > + default: > + return NULL; > + } > + return NULL; > +} Otherwise, patch is good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)