From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100330 invoked by alias); 11 Nov 2015 08:42:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100317 invoked by uid 89); 11 Nov 2015 08:42:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f53.google.com Received: from mail-pa0-f53.google.com (HELO mail-pa0-f53.google.com) (209.85.220.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 11 Nov 2015 08:42:37 +0000 Received: by pabfh17 with SMTP id fh17so25467830pab.0 for ; Wed, 11 Nov 2015 00:42:35 -0800 (PST) X-Received: by 10.66.227.231 with SMTP id sd7mr12504777pac.60.1447231355713; Wed, 11 Nov 2015 00:42:35 -0800 (PST) Received: from E107787-LIN (gcc2-power8.osuosl.org. [140.211.9.43]) by smtp.gmail.com with ESMTPSA id i9sm8222076pbq.93.2015.11.11.00.42.33 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 11 Nov 2015 00:42:35 -0800 (PST) From: Yao Qi To: Marcin =?utf-8?Q?Ko=C5=9Bcielnicki?= Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] gdb/testsuite/gdb.trace: Deduplicate set_point assembly. References: <1447154499-22247-1-git-send-email-koriakin@0x04.net> <1447154499-22247-2-git-send-email-koriakin@0x04.net> Date: Wed, 11 Nov 2015 08:42:00 -0000 In-Reply-To: <1447154499-22247-2-git-send-email-koriakin@0x04.net> ("Marcin \=\?utf-8\?Q\?Ko\=C5\=9Bcielnicki\=22's\?\= message of "Tue, 10 Nov 2015 12:21:39 +0100") Message-ID: <86pozhvseg.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00267.txt.bz2 Marcin Ko=C5=9Bcielnicki writes: > +/* TRACEPOINT_ASM expands to an assembly instruction large enough to fit > + a fast tracepoint jump. The parameter is the label where we'll set > + tracepoints and breakpoints. */ > + > +#if (defined __x86_64__ || defined __i386__) > + > +static void > +x86_trace_dummy () > +{ > + int x =3D 0; > + int y =3D x + 4; > +} > + > +#define TRACEPOINT_ASM(name) \ > + asm (" .global " SYMBOL(name) "\n" \ > + SYMBOL(name) ":\n" \ > + " call " SYMBOL(x86_trace_dummy) "\n" \ > + ) > + > +#elif (defined __aarch64__) > + > +#define TRACEPOINT_ASM(name) \ > + asm (" .global " SYMBOL(name) "\n" \ > + SYMBOL(name) ":\n" \ > + " nop\n" \ > + ) > + > +#else TRACEPOINT_ASM isn't a good name to me. How about FAST_TRACEPOINT_LABEL? Otherwise the patch looks good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)