From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82872 invoked by alias); 10 Dec 2015 15:59:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82854 invoked by uid 89); 10 Dec 2015 15:59:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f44.google.com Received: from mail-pa0-f44.google.com (HELO mail-pa0-f44.google.com) (209.85.220.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 10 Dec 2015 15:59:40 +0000 Received: by pabur14 with SMTP id ur14so49680382pab.0 for ; Thu, 10 Dec 2015 07:59:38 -0800 (PST) X-Received: by 10.66.90.234 with SMTP id bz10mr17761535pab.115.1449763178842; Thu, 10 Dec 2015 07:59:38 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id u67sm19402771pfi.74.2015.12.10.07.59.36 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 10 Dec 2015 07:59:37 -0800 (PST) From: Yao Qi To: Antoine Tremblay Cc: Subject: Re: [PATCH v7 0/8] Support software single step and conditional breakpoints on ARM in GDBServer. References: <1449583641-18156-1-git-send-email-antoine.tremblay@ericsson.com> Date: Thu, 10 Dec 2015 15:59:00 -0000 In-Reply-To: <1449583641-18156-1-git-send-email-antoine.tremblay@ericsson.com> (Antoine Tremblay's message of "Tue, 8 Dec 2015 09:07:13 -0500") Message-ID: <86poyeqopn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00195.txt.bz2 Antoine Tremblay writes: > In this v7: > > * New patch 3 changes magic numbers for syscall check to numbers computed > from xml-syscall. > > * Patch 4 now uses the new xml-syscall function to compare syscalls. > It also uses the INT_REGISTER_SIZE and ARM_PC_REGNUM defines. > > * Patch 5: Fixed Makefile changelog. > > * Patch 6: > ** Cleanup where arm-get-next-pcs.h is included. > ** Move unrelated functions and macros from arm-get-next-pcs.h/.c to arm.= h/.c. > ** Fixed arm/thumb_deal_with_atomic_sequence calls. > ** Fixed changelog Makefile entries. > ** Fixed changelog configure.tgt/srv entries. > ** Use __NR_sigreturn and __NR_rt_sigreturn to check for sigreturn syscall > in GDBServer. Hi Antoine, thanks for the update... FYI, I am reviewing your patches and trying to run various regression tests for them. Even without your patch series, there is a regression (in gdb.base/advance.exp) in aarch64 mutli-arch debugging that is, breakpoint on main isn't hit when aarch64 GDBserver debugs arm program in arm mode (everything works fine if the arm program is in thumb mode). I suspect that it is related to my recent patch turning Z0 packet on for aarch64 mutli-arch debugging. I really want to clean the room first before we add news things in, so I'll fix the regression first, and then come back to review your patches. --=20 Yao (=E9=BD=90=E5=B0=A7)