From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74663 invoked by alias); 4 Mar 2016 12:03:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74654 invoked by uid 89); 4 Mar 2016 12:03:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:950, decoding, HX-Received:10.66.218.196 X-HELO: mail-pa0-f68.google.com Received: from mail-pa0-f68.google.com (HELO mail-pa0-f68.google.com) (209.85.220.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 04 Mar 2016 12:03:44 +0000 Received: by mail-pa0-f68.google.com with SMTP id gc2so2325513pab.0 for ; Fri, 04 Mar 2016 04:03:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=0e6P8pGFIQifuPkZC+cDJTe17bwq5m5AUyZZjhHSy6U=; b=lWMA/Z5eHTrAW12i+/xsXYT9cvRNClNMHzbFSTMI0JdiE2+8w6oLINOmdHoiy2cEHN SF8a8tLxa/o04lJd5JXbVODemRYN0Z/pX3hpGdPZcrPcpFr1tq7sNdgMMs4Hz0czFKpz /S2tolyJEHOzuh+96lbZ6ZHy0gFvcY6cvatNfOnzL9xsUOSbS3H5EtM1K/queHNABbCo hjxz+RIysDI4aUu+YowR2kB1xwT95f24jfjXfijlELxp/CVIcZkK7YgHxqt1qPmkuqdl Hgfaz0i/gzwdSBrkNIB561EYuMhpzmHUCY73G+bw1yOmVbdSAS9g6VKap116zRXTj2lx wt7Q== X-Gm-Message-State: AD7BkJLO7zKIXFCdV4pdX0Qzd3r8n0ifQwxIaM6DVRjfWUXwapcWnj+PoBq4OK8nSmPczg== X-Received: by 10.66.218.196 with SMTP id pi4mr11280429pac.147.1457093022785; Fri, 04 Mar 2016 04:03:42 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id dw2sm5201348pab.14.2016.03.04.04.03.40 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 04 Mar 2016 04:03:41 -0800 (PST) From: Yao Qi To: Simon Marchi Cc: Subject: Re: [PATCH 0/2] Decouple ARM instruction decoding/relocating from GDB References: <1456415245-24005-1-git-send-email-simon.marchi@ericsson.com> Date: Fri, 04 Mar 2016 12:03:00 -0000 In-Reply-To: <1456415245-24005-1-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Thu, 25 Feb 2016 10:47:23 -0500") Message-ID: <86pova8n6u.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00077.txt.bz2 Simon Marchi writes: Hi Simon, > As part of the upcoming ARM fast tracepoint support, we need to have some= code > in gdbserver that decodes the relocated instructions, to check whether th= ey > need to be modified or not (whether the result of their execution depends= on > their particular PC). Instead of writing new code from scratch, we shoul= d take > advantage of the code already written for the displaced stepping feature = in > GDB, as AArch64 does. To make this possible, we first need to decouple t= he > instruction decoding part from GDB, so that the code can eventually be mo= ved to > a shared location. Could you include these two patches into your arm fast tracepoint patch series? The problems in the code can't be found until we use the code, so I'd like to review them together when arm fast tracepoint patches are ready. --=20 Yao (=E9=BD=90=E5=B0=A7)