From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6070 invoked by alias); 23 Mar 2016 16:21:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6053 invoked by uid 89); 23 Mar 2016 16:21:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pf0-f178.google.com Received: from mail-pf0-f178.google.com (HELO mail-pf0-f178.google.com) (209.85.192.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 23 Mar 2016 16:20:52 +0000 Received: by mail-pf0-f178.google.com with SMTP id n5so34229510pfn.2 for ; Wed, 23 Mar 2016 09:20:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=bWaK5ocWZL+QFBKcd/sSKY+UDYMkm5M2RetJax4jDVg=; b=D/CjPdn9MG/vzQC0KJDu7QvhV940PHLPZ8PKXXiHrwcZMNPBjEZlcLVHDLN58WwHuu 5vHBoe44Qiwe5iAJFJjsnZwt2xB7E7Z23xD0S9Lh+El428/dDmgd3gE1h+mVVTvsx8gA 2EY6ww+EYJqJUBsL6jyaPg9Yv9MhEGtF7/PkU2ES8Jl1iLk97Rv7ZfYQMs0s3zN28O0L ZQOVxZCapPnRJPYzouSQRffKL0MMZFQTgx+RhJWNO6hYilcxILGjRM1YN0I7a06828P8 dTMghdKXwMMjn0qj3uTHw7fejDWnrbsnsHlHRbt8z1fYHeNJZhwlM/Uu9TAD8DdNJg8f FVBQ== X-Gm-Message-State: AD7BkJIOWGDTs+YtD24rVN+h8A3f/gutOJqp0KcoshoGZutgWRKYpDlrFN2Hoe0QSuzOLA== X-Received: by 10.66.218.196 with SMTP id pi4mr5444327pac.147.1458750050484; Wed, 23 Mar 2016 09:20:50 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id o7sm5271230pfa.37.2016.03.23.09.20.48 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 23 Mar 2016 09:20:49 -0700 (PDT) From: Yao Qi To: Artemiy Volkov Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [PR gdb/19820] gdb: allow enumeration constants as second operand of BINOP_REPEAT References: <1458494257-30862-1-git-send-email-artemiyv@acm.org> Date: Wed, 23 Mar 2016 16:21:00 -0000 In-Reply-To: <1458494257-30862-1-git-send-email-artemiyv@acm.org> (Artemiy Volkov's message of "Sun, 20 Mar 2016 10:17:37 -0700") Message-ID: <86poultbc1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00479.txt.bz2 Artemiy Volkov writes: > A couple of tests is also included in this patch to demonstrate that it is > working as intended. > > gdb/Changelog: > > 2016-03-20 Artemiy Volkov > Add "PR gdb/19820" here... > * eval.c (evaluate_subexp_standard): Allow TYPE_CODE_ENUM to be > the type of BINOP_REPEAT's second operand. > > gdb/testsuite/Changelog: > > 2016-03-20 Artemiy Volkov > and here... > * gdb.base/printcmds.exp: Add artificial arrays tests. You can reference existing ChangeLog entries. Did you run regression tests? If the test is regression free, the patch is OK to me with the ChangeLog entry fix I point out above. --=20 Yao (=E9=BD=90=E5=B0=A7)