From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59084 invoked by alias); 28 Jun 2017 08:28:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58613 invoked by uid 89); 28 Jun 2017 08:28:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1012, HCc:D*ca, H*r:sk:static. X-HELO: mail-it0-f50.google.com Received: from mail-it0-f50.google.com (HELO mail-it0-f50.google.com) (209.85.214.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Jun 2017 08:28:45 +0000 Received: by mail-it0-f50.google.com with SMTP id m68so26214150ith.1 for ; Wed, 28 Jun 2017 01:28:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=A8a10ZyLRD4MfaXKGey9TP7+OjPmO0E0vuDyelMRxt4=; b=DPuVPyKny89TTqQ+Xy2e6DA0mMfLT392xAIEPEjQEV1g84MpAvpCqT41nTjXPy5zyK 9Fb6gRKGxmaj7KSpnEFDXPG6PJt2nANDVRtupdjNN5L294GeuOPaQDtdje9jEFZtMHPM 6YDUwGwiUtNVUsjIzw79vWzj5P0wgrBFsJKtzbk7TgcoFT7NMsLcnH1JSB3DbCPb7eIh 8Jddb2eSd+nJ3TM75R99/26HIzSR1sSqnbzcLkInwWPlcO0Pm+vgr1deQur1wQRzTq4I cn+Y8beeLUx2GLaCe8IRLBgt/WzC51AvfyRKfVqbIR+Z9IfqqYM0iMuGtJ6RnGePRxB+ zr4g== X-Gm-Message-State: AKS2vOzpLQQ/F774OCR6S1eeRHChHQqJzAEze6REIYQCSfCDmp8VPzwj JYH+0KKCBwAPlA== X-Received: by 10.36.189.198 with SMTP id x189mr6502264ite.56.1498638523875; Wed, 28 Jun 2017 01:28:43 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id f195sm877150iof.54.2017.06.28.01.28.42 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 28 Jun 2017 01:28:43 -0700 (PDT) From: Yao Qi To: Alan Hayward Cc: Simon Marchi , "gdb-patches\@sourceware.org" , "Tedeschi\, Walfred" , nd Subject: Re: [PATCH 00/25 V2] Make GDB builtin target descriptions more flexible References: <1497256916-4958-1-git-send-email-yao.qi@linaro.org> <84DF3A06-41F2-4061-95AA-B35E3D299C90@arm.com> Date: Wed, 28 Jun 2017 08:28:00 -0000 In-Reply-To: <84DF3A06-41F2-4061-95AA-B35E3D299C90@arm.com> (Alan Hayward's message of "Tue, 27 Jun 2017 13:49:14 +0000") Message-ID: <86podoecso.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00759.txt.bz2 Alan Hayward writes: Hi Alan, > Parts of gdbserver/linux-x86-tdesc.c is duplicated in i386-linux-tdep.c, > and the same for other -tdesc.c files. > Would it be better to move the -tdesc.c files into a common directory, > maybe nat/ ? Yes, there is a duplication, Walfred asked it too. See my reply https://sourceware.org/ml/gdb-patches/2017-06/msg00758.html The code creating target descriptions for each target should be shared somewhere, in arch/?. We need to change each backend to migrate to the new style of creating target descriptions, and share code with GDBserver if needed. This project needs help converting interesting backends to the new style of target description creation. > > How is linux-x86-tdesc-ipa.o built? I can see the entry in configure.srv, > but I can=E2=80=99t find a .c either in my src or build directory. linux-x86-tdesc-ipa.o is built from linux-x86-tdesc.c for IPA. --=20 Yao (=E9=BD=90=E5=B0=A7)